Remove redundant subdomains from shared credentials#1081
Open
Ronitsabhaya75 wants to merge 1 commit into
Open
Conversation
This PR removes subdomains from shared-credentials.json that are redundant because their parent domains are already present in the exact same credential group. Subdomains are automatically included in password manager resource checks when a parent domain is matched, so listing them explicitly is unnecessary. Co-authored-by: renish <renishpate2482001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall Checklist
for shared-credentials.json
shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use asharedassociation fromgoogle.co.iltogoogle.com, becausegoogle.co.ilredirects toaccounts.google.comfor sign in.)fromandto, the new group, thefromdomain(s) redirect to thetodomain to log in.Description of Changes
This PR removes several subdomains from
shared-credentials.jsonthat are redundant because their parent domains are already present in the exact same credential group.Since password manager resources automatically include subdomains when a parent domain is matched, explicitly listing these subdomains alongside their parents is unnecessary.
The removed subdomains are:
login.workflowmanager.app(covered byworkflowmanager.app)community.pioneerdj.com(covered bypioneerdj.com)hk.jobsdb.com,sg.jobsdb.com,th.jobsdb.com(covered byjobsdb.com)No new groups were added; this is strictly an optimization/cleanup of the existing data structure.