Skip to content

Remove redundant subdomains from shared credentials#1081

Open
Ronitsabhaya75 wants to merge 1 commit into
apple:mainfrom
Ronitsabhaya75:new-fix
Open

Remove redundant subdomains from shared credentials#1081
Ronitsabhaya75 wants to merge 1 commit into
apple:mainfrom
Ronitsabhaya75:new-fix

Conversation

@Ronitsabhaya75
Copy link
Copy Markdown
Contributor

Overall Checklist

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)
  • If using from and to, the new group, the from domain(s) redirect to the to domain to log in.

Description of Changes

This PR removes several subdomains from shared-credentials.json that are redundant because their parent domains are already present in the exact same credential group.

Since password manager resources automatically include subdomains when a parent domain is matched, explicitly listing these subdomains alongside their parents is unnecessary.

The removed subdomains are:

  • login.workflowmanager.app (covered by workflowmanager.app)
  • community.pioneerdj.com (covered by pioneerdj.com)
  • hk.jobsdb.com, sg.jobsdb.com, th.jobsdb.com (covered by jobsdb.com)

No new groups were added; this is strictly an optimization/cleanup of the existing data structure.

This PR removes subdomains from shared-credentials.json that are redundant because their parent domains are already present in the exact same credential group. Subdomains are automatically included in password manager resource checks when a parent domain is matched, so listing them explicitly is unnecessary.

Co-authored-by: renish <renishpate2482001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant