Add change password URL and password rule quirks for vagaro.com, weve…#1091
Merged
Conversation
dmmaslenn
force-pushed
the
add-more-quirks
branch
from
db2d230 to
51d92a5
Compare
aabosh
requested changes
May 12, 2026
| "password-rules": "minlength: 8; maxlength: 50; max-consecutive: 2; required: lower; required: upper; required: digit; allowed: [-!\"#&'()+,./?@];" | ||
| }, | ||
| "vagaro.com": { | ||
| "password-rules": "minlength: 9; required: lower; required: upper; required: digit; required: [@$!%*?&]; allowed: lower, upper, digit, [@$!%*?&];" |
Collaborator
There was a problem hiding this comment.
Do we need the allowed here?
Contributor
There was a problem hiding this comment.
We do not. We should remove it.
rmondello
requested changes
May 12, 2026
| "weather.com": "https://weather.com/member/settings", | ||
| "webmd.com": "https://member.webmd.com/password-reset", | ||
| "welt.de": "https://signin.auth.welt.de/change-password", | ||
| "weverse.io": "https://weverse.io/more", |
Contributor
There was a problem hiding this comment.
Is this a high quality change password URL?
Collaborator
Author
There was a problem hiding this comment.
Added more specific URL.
| "password-rules": "minlength: 8; maxlength: 50; max-consecutive: 2; required: lower; required: upper; required: digit; allowed: [-!\"#&'()+,./?@];" | ||
| }, | ||
| "vagaro.com": { | ||
| "password-rules": "minlength: 9; required: lower; required: upper; required: digit; required: [@$!%*?&]; allowed: lower, upper, digit, [@$!%*?&];" |
Contributor
There was a problem hiding this comment.
We do not. We should remove it.
dmmaslenn
force-pushed
the
add-more-quirks
branch
from
51d92a5 to
d9d175c
Compare
rmondello
approved these changes
May 12, 2026
aabosh
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rse.io
Overall Checklist
for password-rules.json
for change-password-URLs.json
https://example.com/.well-known/change-password)