initial version of DictionaryProtocol#304
Open
JaapWijnen wants to merge 1 commit into
Open
Conversation
Author
|
Ah forget about the SetProtocol remark. Forgot that the regular Dictionary's Keys is not strictly a Set. |
Author
Author
|
I haven't looked at this in a while and this probably needs more discussion before merging. Would love to work on it more though if anyone has suggestions and/Or feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first attempt at implementing a
DictionaryProtocolprotocol as discussed in #293This is not complete yet and needs discussion in order to improve!
For now it conforms stdlib
DictionaryandOrderedDictionaryto the newly introducedDictionaryProtocol.A basic first definition of a
MutableDictionaryProtocolhas been created but no conformances added yet. (Want to get the base protocol right first and perhaps identify methods that we would want a mutable version to have)Hoping to get some feedback on the current implementation and will add conformances to the other Dictionary objects next.
Would we also like to introduce a
SetProtocol? Should we consider this first since Dictionaries often depend on some type ofSetof keys? Or do we keep the keys collection more generic than constraining it to aSetkind of type?Not all checks are done since this is still in development :) Would love to hear people's thoughts!
Checklist