Review feedback

Author: agnosticdev

Sources/SwiftNetwork/Protocols/Checksum.swift

@@ -62,16 +62,16 @@ struct ChecksumFlags: OptionSet {
     static let partial = ChecksumFlags(rawValue: 0x01)
     static let zeroInvert = ChecksumFlags(rawValue: 0x02)
     static let ip = ChecksumFlags(rawValue: 0x04)
-    static let tcpv4 = ChecksumFlags(rawValue: 0x08)
-    static let udpv4 = ChecksumFlags(rawValue: 0x10)
-    static let tcpv6 = ChecksumFlags(rawValue: 0x20)
-    static let udpv6 = ChecksumFlags(rawValue: 0x40)
+    static let tcpIPv4 = ChecksumFlags(rawValue: 0x08)
+    static let udpIPv4 = ChecksumFlags(rawValue: 0x10)
+    static let tcpIPv6 = ChecksumFlags(rawValue: 0x20)
+    static let udpIPv6 = ChecksumFlags(rawValue: 0x40)
 }
 
 struct InterfaceChecksumFlags: OptionSet {
     let rawValue: UInt32
-    static let csumUDP = InterfaceChecksumFlags(rawValue: 0x0000_0004)
-    static let csumUDPIPV6 = InterfaceChecksumFlags(rawValue: 0x0000_0040)
+    static let csumUDPIPv4 = InterfaceChecksumFlags(rawValue: 0x0000_0004)
+    static let csumUDPIPv6 = InterfaceChecksumFlags(rawValue: 0x0000_0040)
 }
 
 @available(Network 0.1.0, *)

Sources/SwiftNetwork/Protocols/UDPProtocol.swift

@@ -159,9 +159,9 @@ public struct UDPProtocol: NetworkProtocol {
             if self.maximumDatagramSize > UDPProtocol.headerLength {
                 self.maximumDatagramSize -= UDPProtocol.headerLength
             }
-            let udpCsumOffload: UInt32 = path.hardwareChecksumFlags
-            if isIPv4 && ((udpCsumOffload & InterfaceChecksumFlags.csumUDP.rawValue) != 0)
-                || !isIPv4 && ((udpCsumOffload & InterfaceChecksumFlags.csumUDPIPV6.rawValue) != 0)
+            let udpChecksumOffload: UInt32 = path.hardwareChecksumFlags
+            if isIPv4 && ((udpChecksumOffload & InterfaceChecksumFlags.csumUDPIPv4.rawValue) != 0)
+                || !isIPv4 && ((udpChecksumOffload & InterfaceChecksumFlags.csumUDPIPv6.rawValue) != 0)
             {
                 self.flags.insert(.fullChecksumOffload)
                 self.flags.remove(.partialChecksumOffload)
@@ -218,6 +218,7 @@ public struct UDPProtocol: NetworkProtocol {
                 if udpOptions.fullChecksumOffload {
                     self.flags.insert(.fullChecksumOffload)
                 }
+                #if !NETWORK_EMBEDDED
                 if let transport = parameters.defaultStack.transport {
                     if transport.options == udpOptions, udpOptions.useQUICStats {
                         self.flags.insert(.upperTransportIsQUIC)
@@ -228,6 +229,7 @@ public struct UDPProtocol: NetworkProtocol {
                         self.flags.insert(.upperTransportIsQUIC)
                     }
                 }
+                #endif
             }
         }
 
@@ -436,8 +438,8 @@ public struct UDPProtocol: NetworkProtocol {
                     if self.flags.contains(.fullChecksumOffload) {
                         let csumFlags: ChecksumFlags =
                             isIPv4
-                            ? [.udpv4, .zeroInvert]
-                            : [.udpv6, .zeroInvert]
+                            ? [.udpIPv4, .zeroInvert]
+                            : [.udpIPv6, .zeroInvert]
                         frame.checksumOffloadFlags |= csumFlags.rawValue
                     }