Skip to content

Commit 93ccf9e

Browse files
committed
Review feedback
1 parent 6946f2f commit 93ccf9e

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

Sources/SwiftNetwork/Protocols/Checksum.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ struct ChecksumFlags: OptionSet {
7070

7171
struct InterfaceChecksumFlags: OptionSet {
7272
let rawValue: UInt32
73-
static let csumUDPIPv4 = InterfaceChecksumFlags(rawValue: 0x0000_0004)
74-
static let csumUDPIPv6 = InterfaceChecksumFlags(rawValue: 0x0000_0040)
73+
static let udpIPv4 = InterfaceChecksumFlags(rawValue: 0x0000_0004)
74+
static let udpIPv6 = InterfaceChecksumFlags(rawValue: 0x0000_0040)
7575
}
7676

7777
@available(Network 0.1.0, *)

Sources/SwiftNetwork/Protocols/UDPProtocol.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,8 @@ public struct UDPProtocol: NetworkProtocol {
160160
self.maximumDatagramSize -= UDPProtocol.headerLength
161161
}
162162
let udpChecksumOffload: UInt32 = path.hardwareChecksumFlags
163-
if isIPv4 && ((udpChecksumOffload & InterfaceChecksumFlags.csumUDPIPv4.rawValue) != 0)
164-
|| !isIPv4 && ((udpChecksumOffload & InterfaceChecksumFlags.csumUDPIPv6.rawValue) != 0)
163+
if isIPv4 && ((udpChecksumOffload & InterfaceChecksumFlags.udpIPv4.rawValue) != 0)
164+
|| !isIPv4 && ((udpChecksumOffload & InterfaceChecksumFlags.udpIPv6.rawValue) != 0)
165165
{
166166
self.flags.insert(.fullChecksumOffload)
167167
self.flags.remove(.partialChecksumOffload)
@@ -444,8 +444,8 @@ public struct UDPProtocol: NetworkProtocol {
444444
}
445445

446446
if !self.flags.contains(.fullChecksumOffload) {
447-
var noChecksumOffload = !self.flags.contains(.partialChecksumOffload)
448-
if !noChecksumOffload {
447+
var checksumOffloadDisabled = !self.flags.contains(.partialChecksumOffload)
448+
if !checksumOffloadDisabled {
449449
let csumStart = UInt16(isIPv4 ? IPProtocol.ipv4HeaderLength : IPProtocol.ipv6HeaderLength)
450450
let csumWrite = csumStart + UInt16(checksumOffset)
451451
let csumFlags: ChecksumFlags = [.partial, .zeroInvert]
@@ -454,11 +454,11 @@ public struct UDPProtocol: NetworkProtocol {
454454
startOffset: csumStart,
455455
checksumOffset: csumWrite
456456
) {
457-
noChecksumOffload = true
457+
checksumOffloadDisabled = true
458458
}
459459
}
460460

461-
if noChecksumOffload {
461+
if checksumOffloadDisabled {
462462
do throws(ChecksumError) {
463463
try frame.finalizeIPChecksum(checksumOffset: checksumOffset, zeroInvert: true)
464464
} catch {

0 commit comments

Comments
 (0)