Merge pull request #39 from glbrntt/zero-init

agnosticdev · web-flow · commit c22eefb1011a · 2026-07-06T14:01:12.000-07:00
Avoid allocating in FrameArray empty init
diff --git a/Sources/SwiftNetwork/Protocols/FrameArray.swift b/Sources/SwiftNetwork/Protocols/FrameArray.swift
@@ -36,7 +36,7 @@ public struct FrameArray: ~Copyable {
     }
 
     public init() {
-        self.frames = NetworkUniqueDeque<Frame>(minimumCapacity: 1)
+        self.frames = NetworkUniqueDeque<Frame>()
     }
 
     public init(capacity: Int) {
diff --git a/Sources/SwiftNetwork/QUIC/QUICConnection.swift b/Sources/SwiftNetwork/QUIC/QUICConnection.swift
@@ -3196,11 +3196,14 @@ public final class QUICConnection: ManyToManyApplicationStreamProtocol,
         else {
             return false
         }
-        var datagramBatch = FrameArray()
+
+        var datagramBatch: FrameArray
         if self.flowControlState.pendingOutboundBytesToSend > 0 && availableCongestionWindow > 0 {
             datagramBatch = buildOutboundFrameBatch(
                 availableCongestionWindow: (availableCongestionWindow - totalSendBytes)
             )
+        } else {
+            datagramBatch = FrameArray()
         }
 
         // Sending on the current path.

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public struct FrameArray: ~Copyable {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public init() {`
`39`		`- self.frames = NetworkUniqueDeque<Frame>(minimumCapacity: 1)`
	`39`	`+ self.frames = NetworkUniqueDeque<Frame>()`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`public init(capacity: Int) {`
Original file line number	Diff line number	Diff line change
`@@ -3196,11 +3196,14 @@ public final class QUICConnection: ManyToManyApplicationStreamProtocol,`
`3196`	`3196`	`else {`
`3197`	`3197`	`return false`
`3198`	`3198`	`}`
`3199`		`- var datagramBatch = FrameArray()`
	`3199`	`+`
	`3200`	`+ var datagramBatch: FrameArray`
`3200`	`3201`	`if self.flowControlState.pendingOutboundBytesToSend > 0 && availableCongestionWindow > 0 {`
`3201`	`3202`	`datagramBatch = buildOutboundFrameBatch(`
`3202`	`3203`	`availableCongestionWindow: (availableCongestionWindow - totalSendBytes)`
`3203`	`3204`	`)`
	`3205`	`+ } else {`
	`3206`	`+ datagramBatch = FrameArray()`
`3204`	`3207`	`}`
`3205`	`3208`
`3206`	`3209`	`// Sending on the current path.`