Skip to content

Add Reassembly support for Swift IPv6 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agnosticdev merged 3 commits into from
Jul 20, 2026
+846 −49
Merged

Add Reassembly support for Swift IPv6 #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e36663
Add Reassembly support for Swift IPv6
agnosticdev Jul 14, 2026
2629238
Review feedback
agnosticdev Jul 17, 2026
e1dd861
agnosticdev/IPv6Reassembly: Review feedback
agnosticdev Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SwiftNetwork/Protocols/Frame.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ public struct Frame: ~Copyable {
}
return
}
guard newValue < 2 ^ 6 else {
guard newValue < 64 else {

@tfpauly tfpauly Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? It's the same value

@agnosticdev agnosticdev Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting case; when running the test testIPEcho we would receive errors for DSCP values less than 50 in IPv6 cases. This line seemed to be doing bitwise XOR instead of calculating 2 to the power of 6, which is what I think was meant here. Reference on bitwise XOR.

@tfpauly tfpauly Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh good call then. Thanks for fixing.

Logger.proto.fault("Cannot set DSCP value of \(newValue)")
return
}
Expand Down
Loading
Loading