HTTPBodyOutputStream should handle multiple terminal events#95
Merged
Conversation
guoye-zhang
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#94 added a new
cancel()path used by theURLSessiondelegate to clean upHTTPBodyOutputStreamresources on errors received by the delegate but not forwarded to the output stream.As detailed in apple/swift-openapi-generator#918 though, we need to refactor the existing code so that late-arriving terminal events (
endEncountered,wroteFinalChunkanderrorOccurred) from the CFStream delegate and the writer tasks do not trigger a fatalpreconditionFailure()if an error was already forwarded by theURLSessiondelegate viacancel().Modifications
Emit a
debug()log and return an action of.noneif the stream is in aclosedstate when handling anendEncountered,wroteFinalChunkorerrorOccurredevent.Result
There is no longer a race condition that can lead to a fatal
preconditionFailure.Test Plan
Added unit tests to cover specific even handling changes.