From 7cd60431c64acd04d1bdc02725f75b4168c7b190 Mon Sep 17 00:00:00 2001 From: Raphael Hiesgen Date: Tue, 29 Jul 2025 13:00:43 +0100 Subject: [PATCH 1/3] Enable release mode builds ### Motivation: Some errors do not show up in debug builds. Enabling release mode builds improves the CI coverage. ### Modifications: Enable release mode builds for pull requests and nightly builds on main. ### Result: Improved CI coverage. --- .github/workflows/main.yml | 4 ++++ .github/workflows/pull_request.yml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ae944da..5d6b893 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -23,3 +23,7 @@ jobs: with: runner_pool: nightly build_scheme: swift-statsd-client + + release-builds: + name: Release builds + uses: apple/swift-nio/.github/workflows/release_builds.yml@main diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 0861881..7e166bd 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -31,3 +31,7 @@ jobs: with: runner_pool: general build_scheme: swift-statsd-client + + release-builds: + name: Release builds + uses: apple/swift-nio/.github/workflows/release_builds.yml@main From 166db2238db9c0b10303015dc5c3ecff211ea2c4 Mon Sep 17 00:00:00 2001 From: Raphael Hiesgen Date: Tue, 29 Jul 2025 14:00:44 +0100 Subject: [PATCH 2/3] Shim branch that changes windows deafults --- .github/workflows/pull_request.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 7e166bd..38c240d 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -13,7 +13,7 @@ jobs: unit-tests: name: Unit tests - uses: apple/swift-nio/.github/workflows/unit_tests.yml@main + uses: apple/swift-nio/.github/workflows/unit_tests.yml@windows-default-flag with: linux_5_10_arguments_override: "--explicit-target-dependency-import-check error" linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" @@ -34,4 +34,4 @@ jobs: release-builds: name: Release builds - uses: apple/swift-nio/.github/workflows/release_builds.yml@main + uses: apple/swift-nio/.github/workflows/release_builds.yml@windows-default-flag From 79418d5932a3bfcb90c4cc173fdc37871392f1f8 Mon Sep 17 00:00:00 2001 From: Raphael Hiesgen Date: Tue, 29 Jul 2025 14:49:58 +0100 Subject: [PATCH 3/3] Revert "Shim branch that changes windows deafults" This reverts commit 166db2238db9c0b10303015dc5c3ecff211ea2c4. --- .github/workflows/pull_request.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 38c240d..7e166bd 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -13,7 +13,7 @@ jobs: unit-tests: name: Unit tests - uses: apple/swift-nio/.github/workflows/unit_tests.yml@windows-default-flag + uses: apple/swift-nio/.github/workflows/unit_tests.yml@main with: linux_5_10_arguments_override: "--explicit-target-dependency-import-check error" linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" @@ -34,4 +34,4 @@ jobs: release-builds: name: Release builds - uses: apple/swift-nio/.github/workflows/release_builds.yml@windows-default-flag + uses: apple/swift-nio/.github/workflows/release_builds.yml@main