docs: update CHANGELOG/CREDIT/CLAUDE.md for the getopt migration (#991)

- CHANGELOG: record the AutoOpts/libopts -> getopt_long + asciidoctor
  migration under Unreleased, flag the --load-opts/--save-opts and
  help-option removals as breaking, and note the standalone bug fixes
  that rode along with the PR.
- CREDIT: add Gabriel Ganne.
- CLAUDE.md: rewrite the Build and CLI-option sections, which described
  the deleted AutoOpts/.def machinery (out-of-tree configure flags,
  autogen dependency, libopts/ directory, *_opts.def workflow).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: galastar

CLAUDE.md

@@ -34,7 +34,7 @@ Out-of-tree build (used by CI):
 ```
 mkdir build && cd build
 ../autogen.sh
-../configure --disable-local-libopts --enable-debug --enable-test-hexdump
+../configure --enable-debug --enable-test-hexdump
 make
 ```
 
@@ -47,8 +47,9 @@ Useful `./configure` flags when working on specific areas:
   OS-specific, e.g. `eth0` on Linux, `en0` on macOS — see `configure.ac`)
 - `--enable-test-hexdump` - hexdump the pcap on test failure
 
-Requires `libpcap` (and `autogen`/AutoOpts to regenerate `*_opts.def` derived files). On Debian/Ubuntu:
-`apt install autogen libpcap-dev automake autoconf libtool`.
+Requires `libpcap`. `asciidoctor` (Ruby) is only needed to (re)generate the man pages from their
+`docs/*.adoc` sources — release tarballs ship prebuilt man pages. On Debian/Ubuntu:
+`apt install libpcap-dev automake autoconf libtool asciidoctor`.
 
 ## Tests
 
@@ -96,26 +97,34 @@ Notes:
   packet headers belongs here, not in `tcprewrite.c` directly, since `tcpbridge` depends on the same logic.
 - `src/tcpedit/plugins/` - DLT (link-layer type) plugins (`dlt_en10mb`, `dlt_ieee80211`, `dlt_raw`,
   `dlt_linuxsll`, `dlt_hdlc`, `dlt_loop`, `dlt_null`, `dlt_pppserial`, `dlt_radiotap`, `dlt_jnpr_ether`,
-  `dlt_user`, ...) — each implements the same interface (see `dlt_plugins.c`/`dlt_opts.def`) to translate
+  `dlt_user`, ...) — each implements the same interface (see `dlt_plugins.c`) to translate
   a given link layer to/from Ethernet-equivalent processing. `dlt_template`/`dlt_template.sh` scaffold a
   new plugin. Adding a new DLT means adding a plugin here, not branching in generic code.
 - `src/fragroute/` - vendored/adapted fragroute packet-mangling modules (delay, drop, dup, IP/TCP option
   and fragmentation mangling, chaff, reordering) used for traffic-shaping tests.
 - `lib/` - small vendored utility code (`strlcpy`/`strlcat`, `queue.h`, `sll.h`, `tree.h`).
-- `libopts/` - GNU AutoOpts "tearoff" used to generate CLI parsing.
 - `test/` - fixtures and autotools test targets (see Tests section).
-- `docs/` - `HACKING` (contribution/coding-standard doc), `CHANGELOG`, `INSTALL`, `SECURITY.md`, plus a
-  `Makefile.am` that renders the already-built man pages (generated into `src/` from the `*_opts.def`
-  files, see below) to HTML for the website.
-
-### CLI option definitions (`*_opts.def`)
-Each binary's command-line options are declared declaratively in an AutoOpts `.def` file
-(`src/tcpreplay_opts.def`, `src/tcpprep_opts.def`, `src/tcprewrite_opts.def`,
-`src/tcpedit/tcpedit_opts.def`, etc.), not hand-written `getopt` code. `autogen` (AutoGen, from the
-same project as AutoOpts) turns these into generated `*_opts.c`/`.h` and man pages at build time (see
-the `.def` dependency rules in `src/Makefile.am`). When adding/changing a CLI flag, edit the relevant
-`.def` file rather than the generated `_opts.c`. `tcprewrite`/`tcpbridge` include both their own opts
-file and `tcpedit/tcpedit_opts.def` since they expose libtcpedit's rewrite options directly.
+- `docs/` - `HACKING` (contribution/coding-standard doc), `CHANGELOG`, `INSTALL`, `SECURITY.md`, the
+  `*.1.adoc` AsciiDoc man-page sources (see below), plus a `Makefile.am` that renders the man pages to
+  HTML for the website with `asciidoctor`.
+
+### CLI option parsing (`*_args.c`/`*_args.h`)
+Each binary parses its command line with hand-written `getopt_long(3)` code in a matching
+`src/<tool>_args.c`/`.h` pair (`tcpreplay_args.c`, `tcpprep_args.c`, `tcprewrite_args.c`, ...), with
+shared helpers in `src/common/args.c`. The headers expose AutoOpts-style accessor macros (`HAVE_OPT`,
+`OPT_ARG`, `OPT_VALUE_*`) so the consuming code (`*_api.c`, `send_packets.c`, the tcpedit tree) reads
+options the same way it did before the AutoOpts removal. The shared libtcpedit rewrite options
+(`--portmap`, `--enet-*`, DLT plugin options, ...) live in `src/tcpedit/tcpedit_args.c` and are pulled
+into `tcprewrite`, `tcpbridge`, and `tcpreplay-edit`'s option tables via
+`tcpedit_args_long_options()`/`tcpedit_args_handle()`; plugin code consumes them through the macros in
+`src/tcpedit/tcpedit_stub.h` (`tcpedit_optvals[]`). Option constraints (mutually exclusive flags,
+"requires" relationships) are enforced in each parser's `validate_constraints()`.
+
+**Documentation is no longer generated from the option definitions.** Man pages are hand-maintained
+AsciiDoc in `docs/*.1.adoc` (shared tcpedit options in `docs/tcpedit_options.adoc`) and rendered with
+`asciidoctor` (see the rules in `src/Makefile.am`). When adding/changing a CLI flag you must update
+**three** places in tandem: the `*_args.c` option table + handler + `validate_constraints()`, the
+usage text in the same file's `print_usage()`, and the corresponding `docs/*.adoc` man-page source.
 
 ### Packet injection abstraction (`sendpacket_type_t`)
 `src/common/sendpacket.c`/`sendpacket.h` abstract over the many OS-specific ways to inject packets:

docs/CHANGELOG

@@ -1,4 +1,13 @@
 Unreleased
+    - migrate command-line parsing from GNU AutoOpts/libopts to getopt_long(3); the vendored
+      libopts tearoff and the *_opts.def files are removed, and man pages are now generated
+      from AsciiDoc sources in docs/ with asciidoctor (maintainers only; release tarballs
+      ship prebuilt man pages) (#895, #991)
+    - BREAKING: the AutoOpts rc-file options --load-opts/--save-opts and --more-help are
+      removed; --short-help/--long-help are replaced by -h/--less-help and -H/--help (#991)
+    - fix use-after-free of the tcpedit error message on argument parsing failures in
+      tcpreplay-edit and tcpbridge (#991)
+    - tcpprep: require both -i (pcap) and -o (cachefile) instead of either one (#991)
     - send_packets: fix miscalibrated overflow guards in calc_sleep_time() causing tcpreplay to stop
       pacing (-M/-p) and blast remaining packets at full speed on long/high-count replays (#974, #989)
     - sendpacket: bounded retry on EAGAIN/ENOBUFS to prevent endless retry loop / 100% CPU hang (#984, #986)

docs/CREDIT

@@ -156,3 +156,8 @@ blaa <GitHub @blaa>
 
 ABcoders <GitHub @AB-Coder96>
     - diagnosed and validated the calc_sleep_time() overflow, prototype fix (#989)
+
+Gabriel Ganne <gabriel.ganne@gmail.com>
+    - migrate command-line parsing from GNU AutoOpts/libopts to getopt_long(3) and
+      man page generation to asciidoctor (#895, #991)
+    - fix use-after-free of tcpedit error messages, tcpprep -i/-o requirement check