kubedb: correct Memcached and Milvus auth hints

Review against apimachinery: Memcached has an auth secret by default
(GetMemcachedAuthSecretName) so it is username/password, not none; Milvus
has no GetAPIKey (only Qdrant and Weaviate do) so it is username/password,
not apikey. Add known-coordinates and auth-type spot-check tests.

Signed-off-by: Tamal Saha <tamal@appscode.com>

Author: tamalsaha

kubedb/engines.go

@@ -20,8 +20,8 @@ type Engine struct {
 	Resource string
 	// Ports are the engine's default client service ports (informational).
 	Ports []int
-	// AuthType hints how connection credentials are shaped: "password", "apikey"
-	// or "none".
+	// AuthType hints how connection credentials in the {name}-auth secret are shaped:
+	// "password" (username/password) or "apikey" (Qdrant/Weaviate).
 	AuthType string
 }
 
@@ -34,7 +34,7 @@ var engines = map[string]Engine{
 	"elasticsearch": {Name: "elasticsearch", Group: group, Version: "v1", Kind: "Elasticsearch", Resource: "elasticsearches", Ports: []int{9200}, AuthType: "password"},
 	"kafka":         {Name: "kafka", Group: group, Version: "v1", Kind: "Kafka", Resource: "kafkas", Ports: []int{9092}, AuthType: "password"},
 	"mariadb":       {Name: "mariadb", Group: group, Version: "v1", Kind: "MariaDB", Resource: "mariadbs", Ports: []int{3306}, AuthType: "password"},
-	"memcached":     {Name: "memcached", Group: group, Version: "v1", Kind: "Memcached", Resource: "memcacheds", Ports: []int{11211}, AuthType: "none"},
+	"memcached":     {Name: "memcached", Group: group, Version: "v1", Kind: "Memcached", Resource: "memcacheds", Ports: []int{11211}, AuthType: "password"},
 	"mongodb":       {Name: "mongodb", Group: group, Version: "v1", Kind: "MongoDB", Resource: "mongodbs", Ports: []int{27017}, AuthType: "password"},
 	"mysql":         {Name: "mysql", Group: group, Version: "v1", Kind: "MySQL", Resource: "mysqls", Ports: []int{3306}, AuthType: "password"},
 	"perconaxtradb": {Name: "perconaxtradb", Group: group, Version: "v1", Kind: "PerconaXtraDB", Resource: "perconaxtradbs", Ports: []int{3306}, AuthType: "password"},
@@ -53,7 +53,7 @@ var engines = map[string]Engine{
 	"hanadb":      {Name: "hanadb", Group: group, Version: "v1alpha2", Kind: "HanaDB", Resource: "hanadbs", Ports: []int{39017}, AuthType: "password"},
 	"hazelcast":   {Name: "hazelcast", Group: group, Version: "v1alpha2", Kind: "Hazelcast", Resource: "hazelcasts", Ports: []int{5701}, AuthType: "password"},
 	"ignite":      {Name: "ignite", Group: group, Version: "v1alpha2", Kind: "Ignite", Resource: "ignites", Ports: []int{10800}, AuthType: "password"},
-	"milvus":      {Name: "milvus", Group: group, Version: "v1alpha2", Kind: "Milvus", Resource: "milvuses", Ports: []int{19530}, AuthType: "apikey"},
+	"milvus":      {Name: "milvus", Group: group, Version: "v1alpha2", Kind: "Milvus", Resource: "milvuses", Ports: []int{19530}, AuthType: "password"},
 	"mssqlserver": {Name: "mssqlserver", Group: group, Version: "v1alpha2", Kind: "MSSQLServer", Resource: "mssqlservers", Ports: []int{1433}, AuthType: "password"},
 	"oracle":      {Name: "oracle", Group: group, Version: "v1alpha2", Kind: "Oracle", Resource: "oracles", Ports: []int{1521}, AuthType: "password"},
 	"pgpool":      {Name: "pgpool", Group: group, Version: "v1alpha2", Kind: "Pgpool", Resource: "pgpools", Ports: []int{9999}, AuthType: "password"},

kubedb/engines_test.go

@@ -26,6 +26,42 @@ func TestEngines_Complete(t *testing.T) {
 	}
 }
 
+func TestEngines_KnownCoordinates(t *testing.T) {
+	// Spot-check a sample against kubedb.dev/apimachinery to catch registry typos.
+	want := map[string]struct {
+		version, kind, resource, auth string
+	}{
+		"postgres":      {"v1", "Postgres", "postgreses", "password"},
+		"redis":         {"v1", "Redis", "redises", "password"},
+		"mysql":         {"v1", "MySQL", "mysqls", "password"},
+		"memcached":     {"v1", "Memcached", "memcacheds", "password"}, // has auth by default
+		"mssqlserver":   {"v1alpha2", "MSSQLServer", "mssqlservers", "password"},
+		"qdrant":        {"v1alpha2", "Qdrant", "qdrants", "apikey"},
+		"weaviate":      {"v1alpha2", "Weaviate", "weaviates", "apikey"},
+		"milvus":        {"v1alpha2", "Milvus", "milvuses", "password"}, // no API key
+		"perconaxtradb": {"v1", "PerconaXtraDB", "perconaxtradbs", "password"},
+	}
+	for name, w := range want {
+		e, err := Lookup(name)
+		if err != nil {
+			t.Fatalf("Lookup(%q): %v", name, err)
+		}
+		if e.Version != w.version || e.Kind != w.kind || e.Resource != w.resource || e.AuthType != w.auth {
+			t.Errorf("%s = {%s %s %s %s}, want {%s %s %s %s}",
+				name, e.Version, e.Kind, e.Resource, e.AuthType, w.version, w.kind, w.resource, w.auth)
+		}
+	}
+}
+
+func TestEngines_AuthTypeValues(t *testing.T) {
+	for _, name := range SupportedEngines() {
+		e, _ := Lookup(name)
+		if e.AuthType != "password" && e.AuthType != "apikey" {
+			t.Errorf("%s: unexpected AuthType %q", name, e.AuthType)
+		}
+	}
+}
+
 func TestLookup_CaseInsensitiveAndUnknown(t *testing.T) {
 	if e, err := Lookup("PostGres"); err != nil || e.Kind != "Postgres" {
 		t.Fatalf("case-insensitive lookup failed: %+v, %v", e, err)