Use post-delete hook with ordered weights for GatewayClass cleanup

Signed-off-by: Md. Istiak <mdistiak@appscode.com>

Author: Istiak2019331114

charts/service-gateway/templates/cleaner/job.yaml

@@ -6,7 +6,7 @@ metadata:
   namespace: {{ .Release.Namespace }}
   annotations:
     "helm.sh/hook-weight": "0"
-    "helm.sh/hook": pre-delete
+    "helm.sh/hook": post-delete
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
 spec:
   backoffLimit: 3

charts/service-gateway/templates/cleaner/rbac.yaml

@@ -4,8 +4,8 @@ kind: ClusterRole
 metadata:
   name: {{ include "service-gateway.fullname" . }}-gwclass-cleaner-{{ .Release.Namespace }}
   annotations:
-    "helm.sh/hook-weight": "0"
-    "helm.sh/hook": pre-delete
+    "helm.sh/hook-weight": "-4"
+    "helm.sh/hook": post-delete
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
 rules:
 - apiGroups:
@@ -20,8 +20,8 @@ kind: ClusterRoleBinding
 metadata:
   name: {{ include "service-gateway.fullname" . }}-gwclass-cleaner-{{ .Release.Namespace }}
   annotations:
-    "helm.sh/hook-weight": "0"
-    "helm.sh/hook": pre-delete
+    "helm.sh/hook-weight": "-4"
+    "helm.sh/hook": post-delete
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
 roleRef:
   apiGroup: rbac.authorization.k8s.io

charts/service-gateway/templates/cleaner/serviceaccount.yaml

@@ -5,7 +5,7 @@ metadata:
   name: {{ include "service-gateway.fullname" . }}-gwclass-cleaner
   namespace: {{ .Release.Namespace }}
   annotations:
-    "helm.sh/hook-weight": "0"
-    "helm.sh/hook": pre-delete
-    "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
+    "helm.sh/hook-weight": "-5"
+    "helm.sh/hook": post-delete
+    "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded,hook-succeeded
 {{- end }}