Fix objstore secret field emission and set openfga datastore conn limits (#1276)

Signed-off-by: Imtiaz Uddin <imtiaz@appscode.com>

Author: Imtiaz246

charts/ace/README.md

@@ -65,6 +65,8 @@ The following table lists the configurable parameters of the `ace` chart and the
 | s3proxy.enabled                                      |                                                                                                                                                                                                                                                | <code>false</code>                                                                                                                                                                             |
 | openfga.enabled                                      |                                                                                                                                                                                                                                                | <code>false</code>                                                                                                                                                                             |
 | openfga.datastoreURI                                 |                                                                                                                                                                                                                                                | <code>""</code>                                                                                                                                                                                |
+| openfga.datastore.maxOpenConns                       |                                                                                                                                                                                                                                                | <code>20</code>                                                                                                                                                                                |
+| openfga.datastore.connMaxIdleTime                    |                                                                                                                                                                                                                                                | <code>"10m"</code>                                                                                                                                                                             |
 | pgoutbox.enabled                                     |                                                                                                                                                                                                                                                | <code>false</code>                                                                                                                                                                             |
 | outbox-syncer.enabled                                |                                                                                                                                                                                                                                                | <code>false</code>                                                                                                                                                                             |
 | postgres-alerts.enabled                              |                                                                                                                                                                                                                                                | <code>true</code>                                                                                                                                                                              |

charts/ace/templates/platform/objstore-cred.yaml

@@ -12,21 +12,33 @@ metadata:
 type: Opaque
 stringData:
 {{- with $objstore.s3 }}
-  AWS_ACCESS_KEY_ID: '{{ .AWS_ACCESS_KEY_ID }}'
-  AWS_SECRET_ACCESS_KEY: '{{ .AWS_SECRET_ACCESS_KEY }}'
-  ca.crt: {{ .CA_CERT_DATA | default "" | quote }}
+  {{- with .AWS_ACCESS_KEY_ID }}
+  AWS_ACCESS_KEY_ID: {{ . | quote }}
+  {{- end }}
+  {{- with .AWS_SECRET_ACCESS_KEY }}
+  AWS_SECRET_ACCESS_KEY: {{ . | quote }}
+  {{- end }}
+  {{- with .CA_CERT_DATA }}
+  ca.crt: {{ . | quote }}
+  {{- end }}
   {{- with .AWS_REGION }}
-  AWS_REGION: '{{ . }}'
+  AWS_REGION: {{ . | quote }}
   {{- end }}
 {{- end }}
 
 {{- with $objstore.azure }}
-  AZURE_ACCOUNT_NAME: '{{ .AZURE_ACCOUNT_NAME }}'
-  AZURE_ACCOUNT_KEY: '{{ .AZURE_ACCOUNT_KEY }}'
+  {{- with .AZURE_ACCOUNT_NAME }}
+  AZURE_ACCOUNT_NAME: {{ . | quote }}
+  {{- end }}
+  {{- with .AZURE_ACCOUNT_KEY }}
+  AZURE_ACCOUNT_KEY: {{ . | quote }}
+  {{- end }}
 {{- end }}
 
 {{- with $objstore.gcs }}
-  sa.json: {{ .GOOGLE_SERVICE_ACCOUNT_JSON_KEY | default "" | quote }}
+  {{- with .GOOGLE_SERVICE_ACCOUNT_JSON_KEY }}
+  sa.json: {{ . | quote }}
+  {{- end }}
 {{- end }}
 
 {{- end }}

charts/ace/values.yaml

@@ -79,6 +79,9 @@ s3proxy:
 openfga:
   enabled: false
   datastoreURI: ""
+  datastore:
+    maxOpenConns: 20
+    connMaxIdleTime: "10m"
   ## configured in lib-selfhost
   # securityContext: # +doc-gen:break
   #   allowPrivilegeEscalation: false