Skip to content

Commit 88effb3

Browse files
authored
Always render ca.crt and sa.json in objstore secret to allow clearing on upgrade (#1256)
Signed-off-by: Imtiaz Uddin <imtiaz@appscode.com>
1 parent be8fddc commit 88effb3

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

charts/ace/templates/platform/objstore-cred.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ stringData:
1414
{{- if eq $objstore.provider "s3" }}
1515
AWS_ACCESS_KEY_ID: '{{ $objstore.s3.AWS_ACCESS_KEY_ID }}'
1616
AWS_SECRET_ACCESS_KEY: '{{ $objstore.s3.AWS_SECRET_ACCESS_KEY }}'
17-
{{- if $objstore.s3.CA_CERT_DATA }}
18-
ca.crt: {{ $objstore.s3.CA_CERT_DATA | quote }}
19-
{{- end }}
17+
ca.crt: {{ $objstore.s3.CA_CERT_DATA | default "" | quote }}
2018
{{- with $objstore.s3.AWS_REGION }}
2119
AWS_REGION: '{{ . }}'
2220
{{- end }}
@@ -30,7 +28,7 @@ stringData:
3028
{{- end }}
3129

3230
{{- if eq $objstore.provider "gcs" }}
33-
sa.json: '{{ $objstore.gcs.GOOGLE_SERVICE_ACCOUNT_JSON_KEY }}'
31+
sa.json: {{ $objstore.gcs.GOOGLE_SERVICE_ACCOUNT_JSON_KEY | default "" | quote }}
3432
{{- end }}
3533

3634
{{- end }}

charts/outbox-syncer/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: outbox-syncer
33
description: A Helm chart for Kubernetes
44
type: application
55
version: v2026.5.22
6-
appVersion: v0.2.0
6+
appVersion: v0.4.0
77
home: https://github.com/appscode-cloud
88
icon: https://cdn.appscode.com/images/products/bytebuilders/icons/android-icon-192x192.png
99
sources:

0 commit comments

Comments
 (0)