Add AZURE_SECRET_EXPIRES_AT marketplace configuration (#707)

Imtiaz246 · web-flow · commit 9ab4a436ef27 · 2025-02-04T05:17:48.000Z
* Add `AZURE_SECRET_EXPIRES_AT` marketplace configuration

Signed-off-by: Imtiaz Uddin &lt;imtiaz@appscode.com&gt;

* Add datetime format validation in auzre client expires at field

Signed-off-by: Imtiaz Uddin &lt;imtiaz@appscode.com&gt;

---------

Signed-off-by: Imtiaz Uddin &lt;imtiaz@appscode.com&gt;
diff --git a/apis/installer/v1alpha1/ace_options_types.go b/apis/installer/v1alpha1/ace_options_types.go
@@ -333,6 +333,9 @@ type AceOptionsAzureMarketplace struct {
 	TenantID     string `json:"tenantID"`
 	ClientID     string `json:"clientID"`
 	ClientSecret string `json:"clientSecret"`
+	// +optional
+	// +kubebuilder:validation:Format=date-time
+	ClientSecretExpiresAt string `json:"clientSecretExpiresAt"`
 }
 
 type AceOptionsAwsMarketplace struct {
diff --git a/charts/ace/templates/platform/config.yaml b/charts/ace/templates/platform/config.yaml
@@ -213,6 +213,7 @@ stringData:
     AZURE_TENANT_ID = {{ .tenantID }}
     AZURE_CLIENT_ID = {{ .clientID }}
     AZURE_CLIENT_SECRET = {{ .clientSecret }}
+    AZURE_SECRET_EXPIRES_AT = {{ .clientSecretExpiresAt }}
     {{- end }}
 
     {{- with .gcp }}
diff --git a/charts/ace/values.openapiv3_schema.yaml b/charts/ace/values.openapiv3_schema.yaml
@@ -19036,6 +19036,9 @@ properties:
                 type: string
               clientSecret:
                 type: string
+              clientSecretExpiresAt:
+                format: date-time
+                type: string
               secret:
                 type: string
               tenantID:
diff --git a/charts/ace/values.yaml b/charts/ace/values.yaml
@@ -431,6 +431,7 @@ settings:
   #     tenantID: ""
   #     clientID: ""
   #     clientSecret: ""
+  #     clientSecretExpiresAt: ""
   #   gcp:
   #     secret: ""
   #     testUploadID: ""
diff --git a/schema/ace-options/values.openapiv3_schema.yaml b/schema/ace-options/values.openapiv3_schema.yaml
@@ -1780,6 +1780,9 @@ properties:
                 type: string
               clientSecret:
                 type: string
+              clientSecretExpiresAt:
+                format: date-time
+                type: string
               secret:
                 type: string
               tenantID:

Original file line number	Diff line number	Diff line change
`@@ -333,6 +333,9 @@ type AceOptionsAzureMarketplace struct {`
`333`	`333`	TenantID string `json:"tenantID"`
`334`	`334`	ClientID string `json:"clientID"`
`335`	`335`	ClientSecret string `json:"clientSecret"`
	`336`	`+ // +optional`
	`337`	`+ // +kubebuilder:validation:Format=date-time`
	`338`	+ ClientSecretExpiresAt string `json:"clientSecretExpiresAt"`
`336`	`339`	`}`
`337`	`340`
`338`	`341`	`type AceOptionsAwsMarketplace struct {`