Clear stale resource-metadata hubs before generating catalog

image-packer embeds the resource-metadata hubs, but the reloader used by
kmodules.xyz/resource-metadata shadows the embedded copies with
/tmp/hub/<hub> when those directories exist. A stale or empty leftover
there makes image-packer load nothing and emit a broken catalog, so
remove /tmp/hub before running.

The underlying reloader flaw is fixed upstream in gomodules.xyz/x
(gomodules/x#71); this guards catalog generation until that lands and
re-vendors.

Signed-off-by: Tamal Saha <tamal@appscode.com>

Author: tamalsaha

hack/scripts/update-catalog.sh

@@ -16,6 +16,14 @@
 
 set -eou pipefail
 
+# image-packer embeds the resource-metadata hubs (resourceeditors,
+# resourcedescriptors, clusterprofiles), but the reloader used by
+# kmodules.xyz/resource-metadata shadows the embedded copies with
+# /tmp/hub/<hub> when those directories exist. A stale or empty leftover
+# there makes image-packer load nothing and emit a broken catalog, so
+# remove them before running.
+rm -rf /tmp/hub
+
 image-packer list --root-dir=charts --output-dir=catalog
 
 image-packer list-feature-charts --root-dir=charts --output-dir=catalog