small fixes and lint

Author: Ughuuu

apps/game_server_core/lib/game_server/matchmaking/worker.ex

@@ -10,6 +10,13 @@ defmodule GameServer.Matchmaking.Worker do
   Each tick, inside the lock: prune tickets of users that went offline, then
   group the queued tickets by `match_params` and create a hidden lobby per
   formed match. Broadcasts go out after the lock's transaction commits.
+
+      config :game_server_core, GameServer.Matchmaking.Worker,
+        enabled: true               # set false to leave the worker idle
+
+  Disabled in test configs, like the other periodic workers: the tick owns no
+  sandbox connection, so it only produces "database is locked" noise. Tests
+  call `sweep/0` directly.
   """
 
   use GenServer
@@ -28,10 +35,14 @@ defmodule GameServer.Matchmaking.Worker do
 
   @impl true
   def init(_) do
-    Process.send_after(self(), :tick, @initial_delay_ms)
+    # Stays supervised but idle when disabled (tests): the sweep has no sandbox
+    # connection to check out, so it would just stall and then error.
+    if enabled?(), do: Process.send_after(self(), :tick, @initial_delay_ms)
     {:ok, %{}}
   end
 
+  defp enabled?, do: Application.get_env(:game_server_core, __MODULE__, [])[:enabled] != false
+
   @impl true
   def handle_info(:tick, state) do
     _ =

apps/game_server_web/config/test.exs

@@ -77,11 +77,19 @@ config :game_server_web, GameServerWeb.Plugs.RateLimiter, enabled: false
 # keep logging after the test task itself is done.
 config :game_server_core, GameServer.Accounts.StalePresenceSweeper, enabled: false
 
-# Run GameServer.Async side effects inline so assertions observe them without
-# racing, and so a fire-and-forget task can't outlive the test's DB sandbox
-# owner (that surfaced as "client #PID exited" Exqlite disconnects). Kept in
-# sync with the root config/test.exs, which only applies to umbrella runs.
-config :game_server_core, async_inline: true
+# The other periodic workers, for the same reason: neither owns a sandbox
+# connection, and on SQLite they collide with the test's open write transaction
+# ("database is locked"). Tests drive tick/0 and sweep/0 directly.
+config :game_server_core, GameServer.Tournaments.Ticker, enabled: false
+config :game_server_core, GameServer.Matchmaking.Worker, enabled: false
+
+# NOTE: deliberately NOT setting `async_inline: true` here, unlike the root
+# config/test.exs. Payments call GameServer.Async.run/1 from inside a
+# Repo.transaction, and the hook fanout blocks on a Task that needs its own
+# connection — inline, that Task waits on the connection its own caller is
+# holding for the transaction, times out after 15s and rolls back. It fails
+# 7 payments/entitlement tests. The stray "client exited" disconnects that
+# inline mode would silence need a fix in Async/Hooks, not this knob.
 
 # Jobs run inline on demand in tests (no queues/plugins/cron). Kept in sync with
 # the root config/test.exs.
@@ -90,4 +98,5 @@ config :game_server_core, Oban, testing: :manual
 # The declared setting, not just the endpoint's copy: GameServer.Settings
 # validates `auth.secret_key_base` at boot, and dev should not warn about a
 # secret it demonstrably has.
-config :game_server_core, GameServer.Accounts, secret_key_base: "dJoNJZBOt08JlBREyPV5xvuOdwgHPORxK9WHp/k3Cs+g0R9ctyheJ8/CMeg/AdI1"
+config :game_server_core, GameServer.Accounts,
+  secret_key_base: "dJoNJZBOt08JlBREyPV5xvuOdwgHPORxK9WHp/k3Cs+g0R9ctyheJ8/CMeg/AdI1"

apps/game_server_web/test/game_server/leaderboards_test.exs

@@ -272,17 +272,26 @@ defmodule GameServer.LeaderboardsTest do
 
       # Ada is mid-table on purpose: her rank must survive being searched for.
       for {name, score} <- [{"Zoe Top", 900}, {"Ada Lovelace", 500}, {"Bob Last", 100}] do
-        user =
-          AccountsFixtures.user_fixture()
-          |> Ecto.Changeset.change(display_name: name)
-          |> GameServer.Repo.update!()
-
+        user = searchable_user(display_name: name)
         Leaderboards.submit_score(lb.id, user.id, score)
       end
 
       %{leaderboard: lb}
     end
 
+    # Search covers username as well as display_name and label, and fixture
+    # usernames come from a word list that can contain the terms these tests
+    # search for - "foxglove-2812" matched a search for "LOVE" and made the
+    # single-result assertions fail at random. Pin them to something no test
+    # searches for.
+    defp searchable_user(attrs) do
+      attrs = Keyword.put(attrs, :username, "pinned-#{System.unique_integer([:positive])}")
+
+      AccountsFixtures.user_fixture()
+      |> Ecto.Changeset.change(attrs)
+      |> GameServer.Repo.update!()
+    end
+
     test "returns the board-wide rank, not the position within the results", %{leaderboard: lb} do
       assert [record] = Leaderboards.list_records(lb.id, search: "ada")
       assert record.user.display_name == "Ada Lovelace"
@@ -297,7 +306,7 @@ defmodule GameServer.LeaderboardsTest do
     end
 
     test "matches a record's own label", %{leaderboard: lb} do
-      user = AccountsFixtures.user_fixture()
+      user = searchable_user([])
       {:ok, _} = Leaderboards.submit_score(lb.id, user.id, 700, %{})
       {:ok, record} = Leaderboards.get_user_record(lb.id, user.id)
       GameServer.Repo.update!(Ecto.Changeset.change(record, label: "Guest Runner"))

config/test.exs

@@ -76,6 +76,11 @@ config :game_server_core, async_inline: true
 # ticker supervised but idle. Tests drive GameServer.Tournaments.tick/0 directly.
 config :game_server_core, GameServer.Tournaments.Ticker, enabled: false
 
+# Same for the matchmaking sweep: no sandbox connection, and on SQLite it
+# collides with the test's open write transaction ("database is locked").
+# Tests drive GameServer.Matchmaking.Worker.sweep/0 directly.
+config :game_server_core, GameServer.Matchmaking.Worker, enabled: false
+
 # Disable app-level caching in tests to avoid stale reads across assertions.
 # Still provide the multilevel configuration so the cache can start.
 config :game_server_core, GameServer.Cache,