update icon api. Add icons to tournaments, leaderboards, etc.

Author: Ughuuu

.env.example

@@ -81,8 +81,8 @@
 # Directory containing OTP hook plugins.
 # GAMEND_CONTENT_PLUGINS_DIR=modules/plugins
 
-# Base path of the theme JSON. Only locale-suffixed files are loaded
-# (.en.json, ...).
+# Path to the theme JSON. A single file serves every locale; its text is
+# translated via the gettext `theme` domain.
 # GAMEND_CONTENT_THEME_CONFIG=
 
 # ──────────────────────────────────────────────────────────────────────────
@@ -314,7 +314,7 @@
 # ──────────────────────────────────────────────────────────────────────────
 
 # Record a durable per-run snapshot of lobby state, browsable at
-# /admin/lobby-snapshots.
+# /admin/lobby_snapshots.
 # GAMEND_LOBBY_SNAPSHOTS_ENABLED=false
 
 # Cap on KV entries captured per snapshot.

.github/copilot-instructions.md

@@ -103,7 +103,7 @@ LiveViews that require login should **always be placed inside the __existing__ `
         on_mount: [{GameServerWeb.UserAuth, :require_authenticated}] do
         # phx.gen.auth generated routes
         live "/users/settings", UserLive.Settings, :edit
-        live "/users/settings/confirm-email/:token", UserLive.Settings, :confirm_email
+        live "/users/settings/confirm_email/:token", UserLive.Settings, :confirm_email
         # our own routes that require logged in user
         live "/", MyLiveThatRequiresAuth, :index
       end
@@ -228,7 +228,7 @@ API routes use JWT tokens via Guardian for stateless authentication:
 - Push context: `GameServer.Push` — token registry (`register_token/2` upsert, `list_tokens/2`, `delete_token/2`, soft `disable_token/1`) + server-authoritative delivery (`send_to_user/3`, `send_to_users/3`; no public send endpoint).
 - Delivery routes **per token** off `push_tokens.provider` ("fcm" | "apns") through Pigeon dispatchers; unconfigured providers fall back to the zero-config `Log` provider. One Oban job per token on the `push` queue (`GAMEND_PUSH_QUEUE_CONCURRENCY`); large fan-outs expand via `FanoutWorker`.
 - Hooks: `before_push_send/2` (per-recipient veto/rewrite pipeline), `after_push_sent/3` (per-token outcome). `Notifications` bridges committed notifications to push for offline users via the cached `user_has_live_tokens?/1`.
-- API: `POST/GET /api/v1/me/push-tokens`, `DELETE /api/v1/me/push-tokens/:id`; admin under `/api/v1/admin/push/*`; admin page at `/admin/push`. Stale tokens prune via `GAMEND_RETENTION_PUSH_TOKENS_DAYS` (default 270).
+- API: `POST/GET /api/v1/me/push_tokens`, `DELETE /api/v1/me/push_tokens/:id`; admin under `/api/v1/admin/push/*`; admin page at `/admin/push`. Stale tokens prune via `GAMEND_RETENTION_PUSH_TOKENS_DAYS` (default 270).
 
 ### Notifications
 

.github/workflows/build-and-check.yml

@@ -238,6 +238,7 @@ jobs:
         run: |
           MIX_ENV=dev mix gamend.settings.env_example --check
           MIX_ENV=dev mix gamend.settings.guide --check
+          MIX_ENV=dev mix gamend.theme.extract --check
 
       - name: Audit dependencies for known vulnerabilities
         run: MIX_ENV=dev mix deps.audit

CHANGELOG.md

@@ -1,5 +1,72 @@
 # July 2026
 
+- [breaking] **The theme is one file, translated through gettext.**
+  `theme/config.json` replaces the 30 per-locale copies, and its text is
+  translated via the `theme` gettext domain. Two thirds of each copy was
+  structure rather than text, and they drifted — a `theme_color` added to
+  English never reached the other 29. Configuration (colours, hrefs, icons,
+  layout) is now structurally untranslatable. Extract with
+  `mix gamend.theme.extract`; migrate existing per-locale files with
+  `mix gamend.theme.migrate_locales`. `modules/example_config*.json` is gone —
+  nothing loaded it.
+- [breaking] **Quest and leaderboard translations are no longer stored in the
+  database.** The per-locale `metadata["titles"][locale]` /
+  `["descriptions"][locale]` copies, their admin editor and
+  `Quest.localized_title/2` (plus the `Leaderboard` equivalents) are removed —
+  the same duplicate-store problem the theme had. A row now holds only its
+  source text and gettext translates it at render.
+  `mix gamend.content.migrate_metadata` lifts existing per-locale metadata into
+  `content.po` (`--dry-run` to preview, `--prune` to clear the dead keys).
+- [added] **Quest, leaderboard and tournament text is translatable.**
+  `mix gamend.content.extract` reads the titles and descriptions from the
+  database into a `content` domain, so plugin-defined *and* admin-created rows
+  are covered; `GameServerWeb.ContentText` translates them per viewer. Admin
+  pages deliberately keep showing the stored source string.
+- [added] **All 30 locales are fully translated** (352 strings each, up from
+  266) — machine-translated through the CSV round-trip and awaiting native
+  review.
+- [changed] `mix gettext.export_csv` / `import_csv` cover both gettext trees
+  and every domain; the `_config` pseudo-domain and `--config` flag are gone,
+  since theme text is now a normal PO domain.
+- [added] **Quest chains are browsable** — clicking a chained quest shows every
+  tier, including locked ones ahead.
+- [breaking] **A chain lists as one quest.** `list_user_quests` (and
+  `GET /quests/me`) return a single entry per chain — the earliest tier not yet
+  claimed; once all are claimed, the final tier. Previously a finished tier and
+  its unlocked successor listed side by side.
+- [breaking] **String fields in API responses are never `null`** — an unset
+  value serializes as `""` (Godot clients choke on `null` where a string is
+  expected). Applies to REST, realtime payloads and struct-encoded responses
+  alike: `icon_url`, `description`, `recur`, `prerequisite_quest_key`,
+  notification `sender_id`, and friends. Datetimes/numbers keep `null` where
+  absence is semantic.
+- [added] `icon_url` on **notifications, tournaments, groups and leaderboards**
+  (quests already had it). Group admins upload via `POST /groups/:id/icon/upload_url` +
+  `POST /groups/:id/icon`; tournaments and leaderboards take a URL in admin.
+  Entities without an icon fall back to one shared default per type, from the
+  typed icon set in `GameServerWeb.Icons`.
+- [breaking] **API route paths use underscores throughout.** The API mixed the
+  two styles (`/me/push-tokens` next to `/groups/:id/join_requests`); every
+  hyphenated path is renamed, with no redirects. Notably `/users/log-in`,
+  `/users/log-out`, `/users/update-password`,
+  `/users/settings/confirm-email/:token`, `/me/push-tokens`,
+  `/me/friend-requests`, `/me/avatar/upload-url`, `/data-deletion`,
+  `/tournaments/:id/my-match`, `/economy/grant-item`, `/economy/consume-item`
+  and the `/admin/rate-limiting` and `/admin/lobby-snapshots` pages. **Update
+  any external registration of `/data-deletion`** (Meta/Facebook app settings),
+  and note that confirmation links already emailed under the old path will 404.
+- [added] **Two-step icon upload for tournaments, leaderboards and quests**
+  (admins), matching the flow groups and avatars already had:
+  `POST .../icon/upload_url` returns a presigned ticket, the client PUTs the
+  image straight to storage, `POST .../icon` confirms the key. The mechanism
+  now lives in one place, `GameServerWeb.Uploads`, which also confines a
+  client-supplied key to its own entity's prefix.
+- [fixed] Admin `GET`/`PATCH /api/v1/admin/tournaments` documented `icon_url`
+  in its OpenAPI schema but never returned it.
+- [fixed] **Uploaded icons are cached like avatars.** `icons/` now carries the
+  same immutable one-year `Cache-Control` as `avatars/` — every icon key is
+  content-unique (`Storage.build_key/3`), so revalidating one on each page load
+  was pure waste.
 - [added] **Settings**: one declared config surface.
 - [changed] **Guides are markdown files.** `/docs/setup`
 - [changed] **Times are shown in the reader's timezone.**

Dockerfile

@@ -39,6 +39,16 @@ COPY apps/game_server_core/mix.exs apps/game_server_core/mix.exs
 # Install dependencies
 RUN mix deps.get
 
+# Compile-time config must be present before deps compile (mdex reads its
+# syntax highlighter from config). Copied on its own so the layer only busts
+# when config changes, not on every source commit.
+COPY config config
+
+# Compile external deps (hex + git, including the Rust NIFs) in a cached
+# layer. Without this, `COPY . .` below invalidated `mix compile` on every
+# commit and all ~140 deps rebuilt from scratch each CI run. Local path deps
+# (apps/*) are skipped: their sources arrive with COPY and compile next.
+RUN mix deps.compile --skip-local-deps
 
 COPY . .
 

ROADMAP.md

@@ -235,7 +235,7 @@ STORAGE_MAX_UPLOAD_BYTES=5242880
 ```
 
 **Upload flow (client-agnostic, same for Godot/JS):**
-1. Client asks `POST /me/avatar/upload-url` → server validates size/type,
+1. Client asks `POST /me/avatar/upload_url` → server validates size/type,
    returns `{url, method, headers, key}` from `presigned_upload/2`.
 2. Client uploads bytes directly to `url` (S3/R2 or the local endpoint).
 3. Client `POST /me/avatar {key}` → server verifies the object exists and
@@ -311,7 +311,7 @@ current codebase, and the CONTRIBUTING checklist.
   `GameServer.Push` fan-out on the Oban `push` queue; FCM + APNs-direct behind
   one behaviour, routed per token, delivered via **Pigeon 2**.
 - [Push — Godot client](docs/specs/push-godot-client.md) — Android (FCM) then iOS
-  (native APNs) behind one `GamendPush.gd`, registering to `/me/push-tokens`.
+  (native APNs) behind one `GamendPush.gd`, registering to `/me/push_tokens`.
 - [Chat moderation](docs/specs/chat-moderation.md) — word filter + report queue +
   mute, enforced in the existing `before_chat_message` pipeline.
 

apps/game_server_core/config/config.exs

@@ -3,7 +3,7 @@ import Config
 config :game_server_core, ecto_repos: [GameServer.Repo]
 
 default_adapter =
-  if System.get_env("DATABASE_ADAPTER") == "postgres",
+  if System.get_env("GAMEND_DB_ADAPTER") == "postgres",
     do: Ecto.Adapters.Postgres,
     else: Ecto.Adapters.SQLite3
 

apps/game_server_core/lib/game_server/accounts.ex

@@ -1830,7 +1830,7 @@ defmodule GameServer.Accounts do
 
   ## Examples
 
-      iex> deliver_user_update_email_instructions(user, current_email, &url(~p"/users/settings/confirm-email/#{&1}"))
+      iex> deliver_user_update_email_instructions(user, current_email, &url(~p"/users/settings/confirm_email/#{&1}"))
       {:ok, %{to: ..., body: ...}}
 
   """

apps/game_server_core/lib/game_server/content_settings.ex

@@ -10,7 +10,8 @@ defmodule GameServer.ContentSettings do
     label: "Content & plugins"
 
   setting(:theme_config, :string,
-    doc: "Base path of the theme JSON. Only locale-suffixed files are loaded (.en.json, ...)."
+    doc:
+      "Path to the theme JSON. A single file serves every locale; its text is translated via the gettext `theme` domain."
   )
 
   setting(:plugins_dir, :string,

apps/game_server_core/lib/game_server/economy/ledger_entry.ex

@@ -9,18 +9,6 @@ defmodule GameServer.Economy.LedgerEntry do
 
   @type t :: %__MODULE__{}
 
-  @derive {Jason.Encoder,
-           only: [
-             :id,
-             :user_id,
-             :currency,
-             :delta,
-             :balance_after,
-             :reason,
-             :metadata,
-             :inserted_at
-           ]}
-
   schema "ledger_entries" do
     belongs_to :user, GameServer.Accounts.User
     field :currency, :string
@@ -53,3 +41,24 @@ defmodule GameServer.Economy.LedgerEntry do
     |> unique_constraint(:idempotency_key, name: :ledger_entries_idempotency_key_index)
   end
 end
+
+# Hand-written rather than @derive so nil strings encode as "" (see
+# GameServer.SchemaJSON — game clients choke on null).
+defimpl Jason.Encoder, for: GameServer.Economy.LedgerEntry do
+  def encode(entry, opts) do
+    GameServer.SchemaJSON.encode(
+      entry,
+      [
+        :id,
+        :user_id,
+        :currency,
+        :delta,
+        :balance_after,
+        :reason,
+        :metadata,
+        :inserted_at
+      ],
+      opts
+    )
+  end
+end