Skip to content

Commit 306f25f

Browse files
authored
fix: remove extra nfs field in persistentVolume object (#41724)
## Description Removes extra `nfs:` field in the persistentVolume object when EFS enabled. Older Helm versions seem to have just ignored this, but latest Helm does not. Fixes [Issue URL](#40461) > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated Helm chart version to 3.6.10 * Modified persistent volume configuration for EFS-backed storage deployments <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent cb24bb4 commit 306f25f

3 files changed

Lines changed: 6 additions & 7 deletions

File tree

deploy/helm/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ sources:
1111
- https://github.com/appsmithorg/appsmith
1212
home: https://www.appsmith.com/
1313
icon: https://assets.appsmith.com/appsmith-icon.png
14-
version: 3.6.9
14+
version: 3.6.10
1515
dependencies:
1616
- condition: redis.enabled
1717
name: redis

deploy/helm/templates/persistentVolume.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ spec:
3636
{{- if .Values.persistence.efs.enabled }}
3737
csi:
3838
driver: {{ .Values.persistence.efs.driver }}
39-
nfs:
4039
volumeHandle: {{ .Values.persistence.efs.volumeHandle }}
4140
{{ end }}
4241
{{- end }}

deploy/helm/tests/__snapshot__/defaults_snapshot_test.yaml.snap

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
app.kubernetes.io/instance: RELEASE-NAME
2626
app.kubernetes.io/managed-by: Helm
2727
app.kubernetes.io/name: appsmith
28-
appsmith.sh/chart: appsmith-3.6.9
28+
appsmith.sh/chart: appsmith-3.6.10
2929
name: RELEASE-NAME-appsmith
3030
namespace: NAMESPACE
3131
3: |
@@ -36,7 +36,7 @@
3636
app.kubernetes.io/instance: RELEASE-NAME
3737
app.kubernetes.io/managed-by: Helm
3838
app.kubernetes.io/name: appsmith
39-
appsmith.sh/chart: appsmith-3.6.9
39+
appsmith.sh/chart: appsmith-3.6.10
4040
name: RELEASE-NAME-appsmith
4141
namespace: NAMESPACE
4242
spec:
@@ -142,7 +142,7 @@
142142
app.kubernetes.io/instance: RELEASE-NAME
143143
app.kubernetes.io/managed-by: Helm
144144
app.kubernetes.io/name: appsmith
145-
appsmith.sh/chart: appsmith-3.6.9
145+
appsmith.sh/chart: appsmith-3.6.10
146146
name: RELEASE-NAME-appsmith-headless
147147
namespace: NAMESPACE
148148
spec:
@@ -181,7 +181,7 @@
181181
app.kubernetes.io/instance: RELEASE-NAME
182182
app.kubernetes.io/managed-by: Helm
183183
app.kubernetes.io/name: appsmith
184-
appsmith.sh/chart: appsmith-3.6.9
184+
appsmith.sh/chart: appsmith-3.6.10
185185
name: RELEASE-NAME-appsmith
186186
namespace: NAMESPACE
187187
spec:
@@ -202,7 +202,7 @@
202202
app.kubernetes.io/instance: RELEASE-NAME
203203
app.kubernetes.io/managed-by: Helm
204204
app.kubernetes.io/name: appsmith
205-
appsmith.sh/chart: appsmith-3.6.9
205+
appsmith.sh/chart: appsmith-3.6.10
206206
name: RELEASE-NAME-appsmith
207207
namespace: NAMESPACE
208208
secrets:

0 commit comments

Comments
 (0)