Skip to content

ci: remove discontinued XATA_TOKEN usage#41707

Merged
subrata71 merged 1 commit intoreleasefrom
subrata71/xata-token-cleanup
Apr 7, 2026
Merged

ci: remove discontinued XATA_TOKEN usage#41707
subrata71 merged 1 commit intoreleasefrom
subrata71/xata-token-cleanup

Conversation

@subrata71
Copy link
Copy Markdown
Collaborator

@subrata71 subrata71 commented Apr 4, 2026

Summary

  • Replace discontinued Xata database curl calls with touch ~/knownfailures in build-client-server.yml and build-client-server-count.yml (matching the fix already applied to pr-cypress.yml in e61375d)
  • Delete orphaned app/client/cypress/xataadd.sh and app/client/cypress/xatadel.sh scripts that are not referenced by any workflow

Context

XATA Lite has been discontinued. The existing curl calls were silently failing (stderr redirected to /dev/null), producing an empty ~/knownfailures file — identical behavior to the touch replacement. This completes the partial cleanup started in pr-cypress.yml.

After merging, the XATA_TOKEN GitHub secret can be safely removed from the repository settings.

Test plan

  • Verify build-client-server workflow runs successfully on a test PR
  • Verify build-client-server-count workflow runs successfully on a test PR
  • Confirm PR comment behavior for CI failures remains unchanged

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Streamlined CI/CD pipeline by simplifying test failure tracking and validation processes.

Automation

/ok-to-test tags="@tag.Sanity"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/24066890157
Commit: 9982ddf
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Tue, 07 Apr 2026 06:35:51 UTC

XATA Lite has been discontinued. The curl calls to the Xata database
for fetching known Cypress flaky tests were silently failing. This
completes the cleanup started in pr-cypress.yml by applying the same
fix to build-client-server.yml and build-client-server-count.yml,
and removes the orphaned xataadd.sh and xatadel.sh scripts.

The XATA_TOKEN GitHub secret can now be safely removed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog CI labels Apr 4, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 4, 2026

Walkthrough

This pull request removes Xata database integration from CI workflows and test utilities. Workflow steps that previously fetched flaky test data via Xata API calls are replaced with empty placeholder file creation. Associated Bash scripts for adding and deleting records in Xata are deleted entirely.

Changes

Cohort / File(s) Summary
CI Workflow Updates
.github/workflows/build-client-server-count.yml, .github/workflows/build-client-server.yml
Replaced Xata curl/jq calls for fetching known failures with simple touch ~/knownfailures commands in "Get Latest flaky Tests" steps.
Xata Integration Scripts
app/client/cypress/xataadd.sh, app/client/cypress/xatadel.sh
Deleted Bash scripts that performed POST (record creation) and DELETE (record deletion) operations against the Xata CypressKnownFailures table.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

Scripts that spoke to Xata fade away,
Workflows now simpler, come what may,
Touch replaces calls that once did gleam,
Cleaner pipelines—a streamlined dream! 🧹✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing discontinued XATA_TOKEN usage from CI workflows and orphaned scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description covers all required sections with clear context, motivation, and a concrete test plan.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch subrata71/xata-token-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@subrata71 subrata71 self-assigned this Apr 4, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
.github/workflows/build-client-server-count.yml (1)

265-268: Rename this step and keep the migration note inline.

Get Latest flaky Tests no longer matches what this step does. A short note like the one already used in .github/workflows/pr-cypress.yml would make the empty placeholder intentional and easier to understand during the later Cypress DB migration.

♻️ Suggested tweak
-      - name: Get Latest flaky Tests
+      - name: Initialize empty known failures list
         shell: bash
         run: |
+          # Xata Lite has been discontinued; use an empty list until this is migrated to Cypress DB.
           touch ~/knownfailures

Also applies to: 424-427

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/build-client-server-count.yml around lines 265 - 268,
Rename the GitHub Actions step currently titled "Get Latest flaky Tests" to a
clearer name (e.g., "Create placeholder for known failures / Cypress DB
migration note") and replace the empty-touch command comment with a one-line
migration note similar to the style used in .github/workflows/pr-cypress.yml
explaining this is an intentional placeholder for the upcoming Cypress DB
migration; update both occurrences (the step that creates ~/knownfailures and
the other occurrence at the later block) so the step name and inline comment
match and make the placeholder purpose explicit.
.github/workflows/build-client-server.yml (1)

226-229: Make the placeholder behavior explicit here too.

This step now initializes an empty file rather than fetching anything, so the old name is a bit misleading. Mirroring the inline Xata-discontinued note from .github/workflows/pr-cypress.yml would make this transitional behavior much clearer.

♻️ Suggested tweak
-      - name: Get Latest flaky Tests
+      - name: Initialize empty known failures list
         shell: bash
         run: |
+          # Xata Lite has been discontinued; use an empty list until this is migrated to Cypress DB.
           touch ~/knownfailures

Also applies to: 344-347

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/build-client-server.yml around lines 226 - 229, The CI
step named "Get Latest flaky Tests" is misleading because it only creates an
empty placeholder file via the command touch ~/knownfailures; update this step
to make the placeholder behavior explicit by renaming the step (e.g., "Init
placeholder knownfailures (Xata discontinued)") and/or replacing the run body to
include an inline comment or echo explaining Xata was discontinued and this file
is a transitional placeholder (leave the touch command to create the file).
Ensure you apply the same change to the corresponding step that appears later
(the one at the other location referenced in the review).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/build-client-server-count.yml:
- Around line 265-268: Rename the GitHub Actions step currently titled "Get
Latest flaky Tests" to a clearer name (e.g., "Create placeholder for known
failures / Cypress DB migration note") and replace the empty-touch command
comment with a one-line migration note similar to the style used in
.github/workflows/pr-cypress.yml explaining this is an intentional placeholder
for the upcoming Cypress DB migration; update both occurrences (the step that
creates ~/knownfailures and the other occurrence at the later block) so the step
name and inline comment match and make the placeholder purpose explicit.

In @.github/workflows/build-client-server.yml:
- Around line 226-229: The CI step named "Get Latest flaky Tests" is misleading
because it only creates an empty placeholder file via the command touch
~/knownfailures; update this step to make the placeholder behavior explicit by
renaming the step (e.g., "Init placeholder knownfailures (Xata discontinued)")
and/or replacing the run body to include an inline comment or echo explaining
Xata was discontinued and this file is a transitional placeholder (leave the
touch command to create the file). Ensure you apply the same change to the
corresponding step that appears later (the one at the other location referenced
in the review).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 89706ff5-110c-4242-a164-532ee70135c9

📥 Commits

Reviewing files that changed from the base of the PR and between 7f10885 and 9982ddf.

📒 Files selected for processing (4)
  • .github/workflows/build-client-server-count.yml
  • .github/workflows/build-client-server.yml
  • app/client/cypress/xataadd.sh
  • app/client/cypress/xatadel.sh
💤 Files with no reviewable changes (2)
  • app/client/cypress/xataadd.sh
  • app/client/cypress/xatadel.sh

@subrata71 subrata71 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Apr 6, 2026
@subrata71 subrata71 requested a review from yatinappsmith April 6, 2026 12:09
@subrata71 subrata71 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Apr 6, 2026
@subrata71 subrata71 merged commit 89e51a7 into release Apr 7, 2026
425 of 567 checks passed
@subrata71 subrata71 deleted the subrata71/xata-token-cleanup branch April 7, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants