ci: remove discontinued XATA_TOKEN usage#41707
Conversation
XATA Lite has been discontinued. The curl calls to the Xata database for fetching known Cypress flaky tests were silently failing. This completes the cleanup started in pr-cypress.yml by applying the same fix to build-client-server.yml and build-client-server-count.yml, and removes the orphaned xataadd.sh and xatadel.sh scripts. The XATA_TOKEN GitHub secret can now be safely removed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughThis pull request removes Xata database integration from CI workflows and test utilities. Workflow steps that previously fetched flaky test data via Xata API calls are replaced with empty placeholder file creation. Associated Bash scripts for adding and deleting records in Xata are deleted entirely. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.github/workflows/build-client-server-count.yml (1)
265-268: Rename this step and keep the migration note inline.
Get Latest flaky Testsno longer matches what this step does. A short note like the one already used in.github/workflows/pr-cypress.ymlwould make the empty placeholder intentional and easier to understand during the later Cypress DB migration.♻️ Suggested tweak
- - name: Get Latest flaky Tests + - name: Initialize empty known failures list shell: bash run: | + # Xata Lite has been discontinued; use an empty list until this is migrated to Cypress DB. touch ~/knownfailuresAlso applies to: 424-427
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/build-client-server-count.yml around lines 265 - 268, Rename the GitHub Actions step currently titled "Get Latest flaky Tests" to a clearer name (e.g., "Create placeholder for known failures / Cypress DB migration note") and replace the empty-touch command comment with a one-line migration note similar to the style used in .github/workflows/pr-cypress.yml explaining this is an intentional placeholder for the upcoming Cypress DB migration; update both occurrences (the step that creates ~/knownfailures and the other occurrence at the later block) so the step name and inline comment match and make the placeholder purpose explicit..github/workflows/build-client-server.yml (1)
226-229: Make the placeholder behavior explicit here too.This step now initializes an empty file rather than fetching anything, so the old name is a bit misleading. Mirroring the inline Xata-discontinued note from
.github/workflows/pr-cypress.ymlwould make this transitional behavior much clearer.♻️ Suggested tweak
- - name: Get Latest flaky Tests + - name: Initialize empty known failures list shell: bash run: | + # Xata Lite has been discontinued; use an empty list until this is migrated to Cypress DB. touch ~/knownfailuresAlso applies to: 344-347
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/build-client-server.yml around lines 226 - 229, The CI step named "Get Latest flaky Tests" is misleading because it only creates an empty placeholder file via the command touch ~/knownfailures; update this step to make the placeholder behavior explicit by renaming the step (e.g., "Init placeholder knownfailures (Xata discontinued)") and/or replacing the run body to include an inline comment or echo explaining Xata was discontinued and this file is a transitional placeholder (leave the touch command to create the file). Ensure you apply the same change to the corresponding step that appears later (the one at the other location referenced in the review).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/build-client-server-count.yml:
- Around line 265-268: Rename the GitHub Actions step currently titled "Get
Latest flaky Tests" to a clearer name (e.g., "Create placeholder for known
failures / Cypress DB migration note") and replace the empty-touch command
comment with a one-line migration note similar to the style used in
.github/workflows/pr-cypress.yml explaining this is an intentional placeholder
for the upcoming Cypress DB migration; update both occurrences (the step that
creates ~/knownfailures and the other occurrence at the later block) so the step
name and inline comment match and make the placeholder purpose explicit.
In @.github/workflows/build-client-server.yml:
- Around line 226-229: The CI step named "Get Latest flaky Tests" is misleading
because it only creates an empty placeholder file via the command touch
~/knownfailures; update this step to make the placeholder behavior explicit by
renaming the step (e.g., "Init placeholder knownfailures (Xata discontinued)")
and/or replacing the run body to include an inline comment or echo explaining
Xata was discontinued and this file is a transitional placeholder (leave the
touch command to create the file). Ensure you apply the same change to the
corresponding step that appears later (the one at the other location referenced
in the review).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 89706ff5-110c-4242-a164-532ee70135c9
📒 Files selected for processing (4)
.github/workflows/build-client-server-count.yml.github/workflows/build-client-server.ymlapp/client/cypress/xataadd.shapp/client/cypress/xatadel.sh
💤 Files with no reviewable changes (2)
- app/client/cypress/xataadd.sh
- app/client/cypress/xatadel.sh
Summary
touch ~/knownfailuresinbuild-client-server.ymlandbuild-client-server-count.yml(matching the fix already applied topr-cypress.ymlin e61375d)app/client/cypress/xataadd.shandapp/client/cypress/xatadel.shscripts that are not referenced by any workflowContext
XATA Lite has been discontinued. The existing curl calls were silently failing (stderr redirected to
/dev/null), producing an empty~/knownfailuresfile — identical behavior to thetouchreplacement. This completes the partial cleanup started in pr-cypress.yml.After merging, the
XATA_TOKENGitHub secret can be safely removed from the repository settings.Test plan
build-client-serverworkflow runs successfully on a test PRbuild-client-server-countworkflow runs successfully on a test PR🤖 Generated with Claude Code
Summary by CodeRabbit
Automation
/ok-to-test tags="@tag.Sanity"
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/24066890157
Commit: 9982ddf
Cypress dashboard.
Tags:
@tag.SanitySpec:
Tue, 07 Apr 2026 06:35:51 UTC