Skip to content

fix: correct "occured" → "occurred" typo (app error boundary + logo error logs)#41856

Open
DucMinhNe wants to merge 2 commits into
appsmithorg:releasefrom
DucMinhNe:fix/occured-typo
Open

fix: correct "occured" → "occurred" typo (app error boundary + logo error logs)#41856
DucMinhNe wants to merge 2 commits into
appsmithorg:releasefrom
DucMinhNe:fix/occured-typo

Conversation

@DucMinhNe

@DucMinhNe DucMinhNe commented Jun 1, 2026

Copy link
Copy Markdown

Description

Fixes the misspelling occuredoccurred (double r) in three places:

  • app/client/src/index.tsx — the top-level FaroErrorBoundary fallback shown to users when the app crashes: An error has occuredAn error has occurred (user-facing)
  • app/client/src/ce/sagas/WorkspaceSagas.ts — two log.error messages for logo upload/remove failures

Text-only change; no logic, props, or behavior affected.

Type of change

  • Chore (typo / non-functional copy fix)

Testing

No functional change — corrected English spelling in display/log strings only.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected spelling in error messages displayed during logo upload and removal operations.
    • Fixed spelling error in the application's error fallback message.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9a875315-66c0-4240-840d-4409cf8dfd0b

📥 Commits

Reviewing files that changed from the base of the PR and between a0620d9 and 18e519c.

📒 Files selected for processing (2)
  • app/client/src/ce/sagas/WorkspaceSagas.ts
  • app/client/src/index.tsx

Walkthrough

Correct spelling of "occurred" in error messages across logo upload and deletion sagas, and the App component's error boundary fallback UI text.

Changes

Spelling corrections for error messages

Layer / File(s) Summary
Corrected error message spelling
app/client/src/ce/sagas/WorkspaceSagas.ts, app/client/src/index.tsx
Error messages in uploadWorkspaceLogoSaga, deleteWorkspaceLogoSaga, and FaroErrorBoundary fallback text are corrected from misspelled "occured" to "occurred".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

A letter lost, now found with care, 🔤
"occurred" replaces misspelled air,
Three messages corrected true,
Error logs now spelled anew.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: correcting the "occured" to "occurred" typo across two files.
Description check ✅ Passed The description covers the essential details (what was fixed, where, and why), though it lacks a linked issue and the Automation/Communication sections from the template.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions Bot added the Stale label Jun 8, 2026
@DucMinhNe

Copy link
Copy Markdown
Author

Still relevant — this typo appears in a user-facing error message. The PR is rebased-clean and CI is green; happy to update if anything else is needed.

@github-actions github-actions Bot removed the Stale label Jun 12, 2026
@github-actions

Copy link
Copy Markdown

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions Bot added the Stale label Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant