fix(scripts): exclude supervisor logs from deploy-preview recreate wipe#41860
fix(scripts): exclude supervisor logs from deploy-preview recreate wipe#41860wyattwalter wants to merge 1 commit into
Conversation
The RECREATE path in deploy_preview.sh runs `rm -rf /appsmith-stacks/*` after `supervisorctl stop all`, but supervisord itself keeps running and holds files in /appsmith-stacks/logs/supervisor open. The directory therefore cannot be removed and the kubectl exec fails with "Directory not empty", aborting the workflow before the helm upgrade runs. Walk the tree in two passes instead, skipping logs/supervisor while clearing everything else under /appsmith-stacks. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe preview deployment reset logic now uses a selective cleanup sequence: stopping supervisord first, deleting appsmith-stacks content while preserving the logs directory, then cleaning logs subdirectory while preserving the supervisor entry—instead of force-deleting the entire appsmith-stacks tree. ChangesReset logic for supervisord and appsmith-stacks cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/26832642149. |
|
Deploy-Preview-URL: https://ce-41860.dp.appsmith.com |
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
|
This PR has been closed because of inactivity. |
Summary
RECREATEpath inscripts/deploy_preview.shrunsrm -rf /appsmith-stacks/*aftersupervisorctl stop all, butsupervisorditself keeps running and holds files in/appsmith-stacks/logs/supervisoropen. The directory cannot be removed, so thekubectl execstep fails withrm: cannot remove '/appsmith-stacks/logs/supervisor': Directory not emptyand the GitHub Actions job aborts before the helm upgrade ever runs.rm -rf /appsmith-stacks/*with twofindinvocations that walk the tree and skiplogs/supervisor, clearing everything else under/appsmith-stacks.Test plan
recreate=trueon a PR and confirm the wipe step now completes and the workflow proceeds into the helm upgrade.Summary by CodeRabbit