fix(SA-675): exit 0 when membership changes are successfully applied

Previously, any mismatch would trigger non-zero exit even when
ADD_USERS and REMOVE_USERS were enabled and changes were made.
Now only exits non-zero when mismatch exists AND changes were
not configured to be applied (dry-run mode).

Author: gjarzebak95

index.ts

@@ -12,17 +12,27 @@ export async function run(): Promise<void> {
   const usersNotInGithub = new Set(Array.from(googleUsers).filter((x) => !gitHubUsers.has(x)))
 
   const usersNotInGoogle = new Set(Array.from(gitHubUsers).filter((x) => !googleUsers.has(x)))
+  let unfixedMismatch = false
+
   if (usersNotInGithub.size > 0) {
     console.log(`Users not in github: ${Array.from(usersNotInGithub).join(', ')}`)
-    if (config.addUsers) await addUsersToGitHubOrg(usersNotInGithub)
+    if (config.addUsers) {
+      await addUsersToGitHubOrg(usersNotInGithub)
+    } else {
+      unfixedMismatch = true
+    }
   }
 
   if (usersNotInGoogle.size > 0) {
     console.log(`Users not in google: ${Array.from(usersNotInGoogle).join(', ')}`)
-    if (config.removeUsers) await removeUsersFromGitHubOrg(usersNotInGoogle)
+    if (config.removeUsers) {
+      await removeUsersFromGitHubOrg(usersNotInGoogle)
+    } else {
+      unfixedMismatch = true
+    }
   }
 
-  const exitCode = usersNotInGoogle.size > 0 || usersNotInGithub.size > 0 ? config.exitCodeOnMissmatch : 0
+  const exitCode = unfixedMismatch ? config.exitCodeOnMissmatch : 0
 
   process.exit(exitCode)
 }

tests/index.spec.ts

@@ -30,8 +30,24 @@ describe('missmatch', () => {
     await mod.run()
     return expect(processExitSpy).toBeCalledWith(0)
   })
-  it('should exit with 122 if defined when there is a missmatch', async () => {
+  it('should exit with 122 if defined when there is an unfixed missmatch', async () => {
     process.env.EXIT_CODE_ON_MISMATCH = '122'
+    delete process.env.ADD_USERS
+    delete process.env.REMOVE_USERS
+    await mod.run()
+    return expect(processExitSpy).toBeCalledWith(122)
+  })
+  it('should exit with 0 when mismatch is fixed by adding users', async () => {
+    process.env.EXIT_CODE_ON_MISMATCH = '122'
+    process.env.ADD_USERS = 'true'
+    process.env.REMOVE_USERS = 'true'
+    await mod.run()
+    return expect(processExitSpy).toBeCalledWith(0)
+  })
+  it('should exit with 122 when only add is enabled but remove mismatch exists', async () => {
+    process.env.EXIT_CODE_ON_MISMATCH = '122'
+    process.env.ADD_USERS = 'true'
+    delete process.env.REMOVE_USERS
     await mod.run()
     return expect(processExitSpy).toBeCalledWith(122)
   })