Skip to content

Commit 5b64a17

Browse files
committed
addressed comments like duplicate component and use route id
1 parent f09458b commit 5b64a17

3 files changed

Lines changed: 2 additions & 48 deletions

File tree

src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/deleteModal.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
functionId: selectedDeployment.resourceId,
2222
deploymentId: selectedDeployment.$id
2323
});
24-
if (page.url.href.includes(`deployment-${selectedDeployment.$id}`)) {
24+
if (page.route.id?.includes('deployment-[deployment]')) {
2525
goto(
2626
`${base}/project-${page.params.region}-${page.params.project}/functions/function-${page.params.function}/deployments`
2727
);

src/routes/(console)/project-[region]-[project]/functions/function-[function]/delete.svelte

Lines changed: 0 additions & 46 deletions
This file was deleted.

src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deleteDeploymentModal.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
siteId: selectedDeployment.resourceId,
2323
deploymentId: selectedDeployment.$id
2424
});
25-
if (page.url.href.includes(`deployment-${selectedDeployment.$id}`)) {
25+
if (page.route.id?.includes('deployment-[deployment]')) {
2626
goto(
2727
`${base}/project-${page.params.region}-${page.params.project}/sites/site-${page.params.site}/deployments`
2828
);

0 commit comments

Comments
 (0)