Skip to content

Commit f83c3f5

Browse files
committed
fixes code rabbit comments
1 parent 2dffe54 commit f83c3f5

3 files changed

Lines changed: 5 additions & 17 deletions

File tree

src/lib/components/git/repositories.svelte

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
let connectingRepositoryId = $state<string | null>(null);
5454
let loadRepositoriesRequestId = 0;
5555
const limit = 5;
56-
const connectTimeoutMs = 30000;
5756
5857
onMount(() => {
5958
isLoadingRepositories = true;
@@ -279,18 +278,7 @@
279278
on:click={async () => {
280279
connectingRepositoryId = repo.id;
281280
try {
282-
await Promise.race([
283-
Promise.resolve(connect(repo)),
284-
new Promise((_, reject) =>
285-
setTimeout(() => {
286-
reject(
287-
new Error(
288-
'Connection timed out. Please try again.'
289-
)
290-
);
291-
}, connectTimeoutMs)
292-
)
293-
]);
281+
await Promise.resolve(connect(repo));
294282
} catch (error) {
295283
addNotification({
296284
type: 'error',

src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/+page.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@
7474
installationId: selectedInstallationId,
7575
providerRepositoryId: selectedRepository,
7676
providerBranch: nextBranch,
77-
providerSilentMode: data.site?.providerSilentMode || undefined,
78-
providerRootDirectory: data.site?.providerRootDirectory || undefined,
77+
providerSilentMode: data.site?.providerSilentMode ?? undefined,
78+
providerRootDirectory: data.site?.providerRootDirectory ?? undefined,
7979
specification: data.site?.specification || undefined
8080
});
8181
invalidate(Dependencies.SITE);

src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateRepository.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,8 @@
149149
installationId: selectedInstallationId,
150150
providerRepositoryId: selectedRepository,
151151
providerBranch: nextBranch,
152-
providerSilentMode: site?.providerSilentMode || undefined,
153-
providerRootDirectory: site?.providerRootDirectory || undefined,
152+
providerSilentMode: site?.providerSilentMode ?? undefined,
153+
providerRootDirectory: site?.providerRootDirectory ?? undefined,
154154
specification: site?.specification || undefined
155155
});
156156

0 commit comments

Comments
 (0)