feat: added create more functionality#2214
Merged
ItzNotABug merged 9 commits intoAug 22, 2025
Merged
Conversation
ConsoleProject ID: Sites (2)
Note Appwrite has a Discord community with over 16 000 members. |
ItzNotABug
suggested changes
Aug 14, 2025
| } | ||
| } | ||
| }} | ||
| {footer}> |
Contributor
There was a problem hiding this comment.
we already add a snippet footer above, right?
afaik, we should directly be able to use the footer snippet inside the SideSheet, same with children.
ItzNotABug
suggested changes
Aug 18, 2025
| await invalidate(Dependencies.ROW); | ||
|
|
||
| if (createMore) { | ||
| createRow.set(computeInitialCreateRow()); |
Contributor
There was a problem hiding this comment.
lets make a separate function resetCreateRow or invalidateCreateRow, etc.
ItzNotABug
approved these changes
Aug 22, 2025
| text: string; | ||
| disabled?: boolean; | ||
| onClick?: () => void | Promise<void>; | ||
| onClick?: () => boolean | void | Promise<boolean | void>; |
Contributor
There was a problem hiding this comment.
I think with the addition of logic to always return true or false for keeping the sidesheet open, is there a usecase where we return void?
ItzNotABug
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a "Create more" toggle feature to the table row creation sidebar
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes