fix: modernize sessions table component#2220
Merged
Merged
Conversation
ConsoleProject ID: Sites (2)
Note Appwrite has a Discord community with over 16 000 members. |
ItzNotABug
reviewed
Aug 22, 2025
| height="20" | ||
| width="20" | ||
| src={getBrowser(session.clientCode).toString()} | ||
| style="--p-text-size: 1.25rem" |
Contributor
There was a problem hiding this comment.
why do we need a text size on img?
| {:else} | ||
| <span | ||
| class="icon-globe-alt" | ||
| style="--p-text-size: 1.25rem" |
Contributor
There was a problem hiding this comment.
empty tag, same as above unless this is intentional.
ItzNotABug
suggested changes
Aug 24, 2025
| src={getBrowser(session.clientCode).toString()} | ||
| alt={session.clientName} /> | ||
| {:else} | ||
| <span class="icon-globe-alt" aria-hidden="true"> </span> |
Contributor
There was a problem hiding this comment.
Use the Icon component.
| {/each} | ||
| </TableBody> | ||
| </TableScroll> | ||
| <p class="text"> |
Contributor
There was a problem hiding this comment.
do we need paragraph tag here?
ItzNotABug
approved these changes
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace old table components with modern Table.Root from pink-svelte
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes