feat: redesign custom 404 error page#2231
Merged
Merged
Conversation
ConsoleProject ID: Sites (2)
Note Cursor pagination performs better than offset pagination when loading further pages. |
ItzNotABug
suggested changes
Aug 20, 2025
ItzNotABug
suggested changes
Aug 20, 2025
| <Button href={base}>Back to the console</Button> | ||
| <div class="content"> | ||
| <div class="center"> | ||
| <span class="error-badge">404 Page not found</span> |
| <div class="center"> | ||
| <span class="error-badge">404 Page not found</span> | ||
| </div> | ||
| <h1 class="error-title">The page you're looking for doesn't exist.</h1> |
Contributor
There was a problem hiding this comment.
same here for using <Typography.*>? is the font design different?
ItzNotABug
suggested changes
Aug 20, 2025
Comment on lines
+295
to
+299
| @media #{devices.$break1} { | ||
| .side-default { | ||
| padding-block-start: 0; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
we don't need this. instead add the side-default if !$isSmallViewport conditionally.
Comment on lines
+370
to
+377
| .mobile-logo { | ||
| position: fixed; | ||
| bottom: 1.25rem; | ||
| left: 50%; | ||
| transform: translateX(-50%); | ||
| z-index: 10; | ||
| margin-block-start: 0 !important; | ||
| } |
Contributor
There was a problem hiding this comment.
see - https://github.com/appwrite/console/blob/main/static/css/loading.css#L37C1-L44C2
that way, the appwrite icon doesn't shift.
Contributor
There was a problem hiding this comment.
the default slot has a u-margin-block-start-24, lets make it conditional like -
<div class:u-margin-block-start-24={!$isSmallViewport}>
<slot />
</div>
ItzNotABug
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
redesigned custom 404 error page
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes