-
Notifications
You must be signed in to change notification settings - Fork 237
feat: redesign custom 404 error page #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
426f419
9c8d245
06db3a1
7db3391
869c6e2
2291161
acf44eb
1d42aa7
cd370e9
7c9f8ae
0b29335
332512e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,13 +59,13 @@ | |
| {#if $app.themeInUse === 'dark'} | ||
| <img | ||
| src={AppwriteLogoDark} | ||
| width="160" | ||
| width="120" | ||
| class="u-block u-only-dark" | ||
| alt="Appwrite Logo" /> | ||
| {:else} | ||
| <img | ||
| src={AppwriteLogoLight} | ||
| width="160" | ||
| width="120" | ||
| class="u-block u-only-light" | ||
| alt="Appwrite Logo" /> | ||
| {/if} | ||
|
|
@@ -167,18 +167,18 @@ | |
| </ul> | ||
| </div> | ||
| <div | ||
| class="logo u-flex u-gap-16 u-margin-inline-auto is-only-mobile u-margin-block-start-32"> | ||
| class="logo u-flex u-gap-16 u-margin-inline-auto is-only-mobile u-margin-block-start-32 mobile-logo"> | ||
| <a href={base}> | ||
| {#if $app.themeInUse === 'dark'} | ||
| <img | ||
| src={AppwriteLogoDark} | ||
| width="93" | ||
| width="120" | ||
| class="u-block u-only-dark" | ||
| alt="Appwrite Logo" /> | ||
| {:else} | ||
| <img | ||
| src={AppwriteLogoLight} | ||
| width="93" | ||
| width="120" | ||
| class="u-block u-only-light" | ||
| alt="Appwrite Logo" /> | ||
| {/if} | ||
|
|
@@ -291,6 +291,13 @@ | |
| } | ||
| } | ||
|
|
||
| /* mobile only: remove top padding toeliminate extra space */ | ||
| @media #{devices.$break1} { | ||
| .side-default { | ||
| padding-block-start: 0; | ||
| } | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we don't need this. instead add the |
||
|
|
||
| /* for smaller screens */ | ||
| @media #{devices.$break2open} { | ||
| .side-default { | ||
|
|
@@ -359,4 +366,13 @@ | |
| padding-block-start: 5rem; | ||
| } | ||
| } | ||
|
|
||
| .mobile-logo { | ||
| position: fixed; | ||
| bottom: 1.25rem; | ||
| left: 50%; | ||
| transform: translateX(-50%); | ||
| z-index: 10; | ||
| margin-block-start: 0 !important; | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see - https://github.com/appwrite/console/blob/main/static/css/loading.css#L37C1-L44C2 |
||
| </style> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| <script> | ||
| import { base } from '$app/paths'; | ||
| import { page } from '$app/state'; | ||
| import { Button } from '$lib/elements/forms'; | ||
| import { Unauthenticated } from '$lib/layout'; | ||
| import { Typography } from '@appwrite.io/pink-svelte'; | ||
| import { Button } from '$lib/elements/forms'; | ||
| import { Badge, Typography, Layout } from '@appwrite.io/pink-svelte'; | ||
| </script> | ||
|
|
||
| <Unauthenticated> | ||
| <Typography.Title size="xl" | ||
| >{'status' in page.error | ||
| ? page.error.status || 'Invalid Argument' | ||
| : 'Invalid Argument'}</Typography.Title> | ||
| <Typography.Title>{page.error.message}</Typography.Title> | ||
| <Button href={base}>Back to the console</Button> | ||
| <Layout.Stack gap="l" alignItems="center"> | ||
| <Badge variant="secondary" content="404 Page not found" /> | ||
| <Typography.Title size="l" align="center"> | ||
| The page you're looking for doesn't exist. | ||
| </Typography.Title> | ||
| <Button href={base}>Back to console</Button> | ||
| </Layout.Stack> | ||
| </Unauthenticated> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default
slothas au-margin-block-start-24, lets make it conditional like -