feat: added dismissible prop to header alert and email verification b…#2237
Merged
Conversation
ConsoleProject ID: Sites (2)
Note Cursor pagination performs better than offset pagination when loading further pages. |
ItzNotABug
suggested changes
Aug 24, 2025
ItzNotABug
suggested changes
Aug 24, 2025
ItzNotABug
suggested changes
Aug 25, 2025
Meldiron
reviewed
Aug 26, 2025
ItzNotABug
suggested changes
Aug 26, 2025
Comment on lines
+19
to
+20
| const hasUser = $derived(!!$user); | ||
| const needsEmailVerification = $derived($user && !$user.emailVerification); |
Contributor
There was a problem hiding this comment.
we can group users check! one of those is anyways checking for user.
Meldiron
reviewed
Aug 26, 2025
Meldiron
reviewed
Aug 26, 2025
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
ItzNotABug
approved these changes
Aug 27, 2025
Meldiron
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
added dismissible prop to header alert and email verification banner
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes