Skip to content

ci: write image tag to global.image.tag#17

Merged
levivannoort merged 2 commits into
mainfrom
chore/global-image-tag
Jul 3, 2026
Merged

ci: write image tag to global.image.tag#17
levivannoort merged 2 commits into
mainfrom
chore/global-image-tag

Conversation

@levivannoort

Copy link
Copy Markdown
Member

The applications repo moves image to global.image (generic chart 1.7.0 — see appwrite-labs/helm-charts#17); this updates the tag-bump automation to write the single canonical path .global.image.tag in default.yaml.

Merge order: land appwrite-labs/assets-applications#29 first. Until then, an old-style per-alias write still overrides global, so deploys stay correct in either interim state (a stale per-alias tag key would just need removing).

🤖 Generated with Claude Code

The applications repo now sets the image once under `global.image` (generic
chart 1.7.0 fallbacks); the bump writes the single canonical path
`.global.image.tag` in default.yaml instead of per-alias keys.

Merge AFTER appwrite-labs/assets-applications#29 — until then per-alias writes
still override global, so deploys stay correct either way.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@levivannoort levivannoort marked this pull request as ready for review July 3, 2026 11:47
@greptile-apps

greptile-apps Bot commented Jul 3, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the staging deployment workflow to write the image tag to .global.image.tag in default.yaml, aligning with the migration from per-alias image keys to a single global.image path introduced in the generic Helm chart 1.7.0.

  • The yq command now targets .global.image.tag in staging/mcp-for-docs/default.yaml instead of .["mcp-for-docs"].image.tag in fra1.yaml.
  • The git add path is updated consistently to default.yaml, so the modified file will be staged and committed correctly.

Confidence Score: 5/5

Both the yq write and the git add are updated to default.yaml consistently; the change is a straightforward path migration with no dangling references.

The two-line change is internally consistent — the yq command and git add both target default.yaml. A previous review flagged a potential mismatch between those two lines, but in this version of the diff both have been updated correctly, so that concern is resolved.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/staging.yml Updates the image-tag bump to write .global.image.tag in default.yaml instead of the old per-alias path in fra1.yaml; both the yq write target and the git add path are updated consistently.

Reviews (2): Last reviewed commit: "Update staging.yml" | Re-trigger Greptile

@ChiragAgg5k ChiragAgg5k left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot approve this as-is: the workflow now writes to ${{ env.ENVIRONMENT }}/${{ env.PROJECT }}/default.yaml, but the commit step still runs git add ${{ env.ENVIRONMENT }}/${{ env.PROJECT }}/fra1.yaml. That means the modified default.yaml file will not be staged, so the deploy job can report "No changes to commit" and skip pushing the updated tag. Please update the git add path to default.yaml to match the yq target.

@levivannoort levivannoort merged commit 170ede1 into main Jul 3, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants