(fix): address review comments on region routing

Pass through credential-bearing endpoints instead of prefixing the
region onto the userinfo, document that cached regions (including the
'default' sentinel) can be stale for up to CACHE_TTL_SECONDS after a
project migrates, and mark the _endpoint assertion as SDK-internal.

Author: ChiragAgg5k

src/mcp_server_appwrite/server.py

@@ -228,7 +228,9 @@ def build_client_for_request(
 # must be addressed through the region subdomain (e.g.
 # ``https://sgp.cloud.appwrite.io/v1``); other gateways reject project-scoped
 # calls with 401 general_access_forbidden. Regions are looked up once per
-# project via the console API and cached briefly.
+# project via the console API and cached briefly; the 'default' sentinel is
+# cached like any region, so a project that migrates regions may be routed to
+# its old home for up to CACHE_TTL_SECONDS.
 _project_region_cache: dict[str, tuple[str, float]] = {}
 
 
@@ -243,6 +245,10 @@ def resolve_region_endpoint(base_endpoint: str, region: str | None) -> str:
     hostname = split.hostname or ""
     if not hostname or hostname.startswith(f"{region}."):
         return base_endpoint
+    if "@" in split.netloc:
+        # Prefixing the netloc would land the region on the userinfo, not the
+        # host; credential-bearing endpoints are never regional, so pass through.
+        return base_endpoint
     return urlunsplit(split._replace(netloc=f"{region}.{split.netloc}"))
 
 

tests/unit/test_server.py

@@ -666,6 +666,8 @@ def test_resolve_client_routes_target_project_to_home_region(self):
             patch.object(server_module, "_lookup_project_region", return_value="sgp"),
         ):
             client = server_module.resolve_client(target_project="proj")
+        # _endpoint is SDK-internal, but it is the only place the resolved
+        # endpoint is observable without a network call (context.py reads it too).
         self.assertEqual(client._endpoint, "https://sgp.cloud.appwrite.io/v1")