feat: Android SDK update for version 24.1.0#122
Conversation
Greptile SummaryThis PR updates the Android SDK to version 24.1.0, adding three new OAuth providers (
Confidence Score: 4/5Safe to merge; the only item worth confirming is whether All version bumps, enum additions, and doc updates are consistent and correct. The one area worth a second look is
Important Files Changed
Reviews (1): Last reviewed commit: "chore: update Android SDK to 24.1.0" | Re-trigger Greptile |
| fun setCookie(value: String): Client { | ||
| config["cookie"] = value | ||
| addHeader("cookie", value) | ||
| return this | ||
| } |
There was a problem hiding this comment.
setCookie may conflict with the existing cookie jar
The Client is already configured with a ListenableCookieJar (CookiePolicy.ACCEPT_ALL) backed by SharedPreferencesCookieStore. When OkHttp's BridgeInterceptor executes, it adds cookies from the jar to the outgoing Cookie header. Injecting a second raw "cookie" header via addHeader may result in duplicate or merged Cookie headers whose precedence depends on OkHttp internals, potentially overwriting persisted session cookies or confusing the server.
The KDoc states this method is "Used by SDKs that forward an incoming Cookie header in server-side runtimes", but the Android SDK is a client-side SDK that already manages cookies automatically. Callers on Android who invoke this method expecting server-forwarding behaviour may instead see unexpected cookie collisions with the shared-preferences store.
|
Closing — changes not substantial enough to warrant a release. |
This PR contains updates to the SDK for version 24.1.0.
What's Changed
setCookie()method toClientfor forwarding incomingCookieheaders in server-side runtimesFusionauth,Keycloak, andKickOAuth providers toOAuthProviderenumX-Appwrite-Response-Formatheader to1.9.4