Conversation
Walkthrough
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Sources/AppwriteModels/Execution.swift (1)
58-60: Doc fix LGTM; tighten wording and switch to inclusive language.Consider aligning the type wording with the actual
[Headers]model and replacing “whitelisted” with “allowlisted” (do the same for responseHeaders for consistency).- /// HTTP request headers as a key-value object. This will return only whitelisted headers. All headers are returned if execution is created as synchronous. + /// HTTP request headers as an array of header objects (Headers). This returns only allowlisted headers. All headers are returned if the execution is created as synchronous.- /// HTTP response headers as a key-value object. This will return only whitelisted headers. All headers are returned if execution is created as synchronous. + /// HTTP response headers as an array of header objects (Headers). This returns only allowlisted headers. All headers are returned if the execution is created as synchronous.Also applies to: 67-68
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Sources/Appwrite/Query.swift(1 hunks)Sources/AppwriteModels/Execution.swift(1 hunks)
🔇 Additional comments (1)
Sources/Appwrite/Query.swift (1)
283-287: New Query.orderRandom(): looks good; please verify backend support and add a tiny test.Matches existing pattern (no attribute/values). Suggest adding a unit test asserting JSON equals {"method":"orderRandom"} for SDK 12.0.0.
// Pseudocode test XCTAssertEqual(Query.orderRandom(), #"{"method":"orderRandom"}"#)
This PR contains updates to the Apple SDK for version 12.1.0.
Summary by CodeRabbit
New Features
Documentation