-
Notifications
You must be signed in to change notification settings - Fork 62
feat: SDK update for version 25.0.0 #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e0cff7d
chore: update Web SDK to 24.2.0
ChiragAgg5k 1469c61
chore: update Web SDK to 24.2.0
ArnabChatterjee20k 536342a
chore: update Web SDK to 24.3.0
ArnabChatterjee20k 91f674c
chore: sync generated SDK for latest
ArnabChatterjee20k 880b379
chore: restore .github templates and workflows
ArnabChatterjee20k 2da6140
chore: update Web SDK to 25.0.0
ArnabChatterjee20k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The returned unsubscribe function deletes the subscription from local maps and calls
connect(), butconnect()only callssendPendingSubscribes()when the socket is alreadyOPEN— andpendingSubscribeswas just cleared for thissubscriptionId, so nothing is sent.Under the old URL-parameter model, reconnecting with an updated channel list was enough to inform the server. Under the new message-based model the server must receive an explicit
unsubscribeframe. Without it, the server continues routing events for the removed subscription for the lifetime of the connection; they are silently dropped client-side only after a reconnect removes the subscription from the re-subscription list.The
Realtimeservice class'sunsubscribe()closure correctly callssendUnsubscribeMessage([subscriptionId])— the same call is missing here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its fine as the deprecated client.ts shouldn't do this