Skip to content

Commit 36906d2

Browse files
committed
Fix Rust SDK review issues
1 parent f580f21 commit 36906d2

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/SDK/Language/Rust.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,7 @@ protected function getDocsArgumentExample(array $param, string $crateName): stri
795795
$value = $this->getIdentifierOverrides()[$value];
796796
}
797797

798-
return ($param["required"] ?? false) ? $value : "Some({$value})";
798+
return (($param["required"] ?? false) && !($param["nullable"] ?? false)) ? $value : "Some({$value})";
799799
}
800800

801801
if (!empty($param["enumValues"]) || !empty($param["enumName"])) {
@@ -804,7 +804,7 @@ protected function getDocsArgumentExample(array $param, string $crateName): stri
804804
$value = $this->getParamExample($param);
805805
}
806806

807-
return ($param["required"] ?? false) ? $value : "Some({$value})";
807+
return (($param["required"] ?? false) && !($param["nullable"] ?? false)) ? $value : "Some({$value})";
808808
}
809809

810810
/**

templates/rust/Cargo.toml.twig

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ serde_json = "1.0.149"
2323
reqwest = { version = "0.12.28", features = ["json", "multipart", "stream"] }
2424
tokio = { version = "1.48.0", features = ["full"] }
2525
indexmap = ">=2, <2.14"
26-
url = "=2.5.4"
27-
idna = "=1.0.3"
28-
idna_adapter = "=1.0.0"
26+
url = ">=2.5.4, <2.6"
27+
idna = ">=1.0.3, <1.2"
28+
idna_adapter = ">=1.0.0, <1.1"
2929
mime = "0.3.17"
3030
fastrand = "=2.0.2"
3131
thiserror = "1.0.69"

0 commit comments

Comments
 (0)