-
Notifications
You must be signed in to change notification settings - Fork 199
fix(rust): replace unwrap/panic with Result-based error handling #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
yashksaini-coder
wants to merge
11
commits into
appwrite:master
from
yashksaini-coder:fix/rust-result-error-handling
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a5b05ce
feat(rust): add From<InvalidHeaderValue> impl to error type
yashksaini-coder ed9237e
fix(rust): replace unwrap/panic with Result in client setters
yashksaini-coder 7635e2c
fix(rust): update tests and examples for Result-based setters
yashksaini-coder eceecd9
Merge branch 'appwrite:master' into fix/rust-result-error-handling
yashksaini-coder b071cef
Improve error handling for endpoint validation and update test cases …
yashksaini-coder b02908e
Merge branch 'appwrite:master' into fix/rust-result-error-handling
yashksaini-coder f6e331c
Fix SAFETY comment to accurately scope unwrap justifications
yashksaini-coder dd66a3e
Make add_header return Result for consistent error handling with setters
yashksaini-coder 1d5abda
Improve error handling for header value parsing and update test for i…
yashksaini-coder 15c4b71
Merge branch 'appwrite:master' into fix/rust-result-error-handling
yashksaini-coder 42959bc
Merge branch 'appwrite:master' into fix/rust-result-error-handling
yashksaini-coder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set_endpointreturns an error with message "Invalid endpoint URL" but the validation only checks the scheme prefix. This is misleading and allows other malformed URLs through until request time. Consider parsing/validating the endpoint withurl::Urlhere (and still enforcing http/https), and include a clear message about the requirement (e.g., must start with http:// or https://).