Conversation
- Updated AttributeSchema and ColumnSchema to include "bigint". - Implemented creation and update methods for bigint attributes in the Attributes class.
Greptile SummaryThis PR adds Confidence Score: 5/5Safe to merge; changes follow existing patterns and no blocking issues were found. Both changed files follow the exact same conventions as the pre-existing integer type: the schema enum is extended, create/update handlers delegate to the appropriate SDK method with matching parameters, and array is correctly omitted from the update call. No new edge cases are introduced. No files require special attention.
|
| Filename | Overview |
|---|---|
| templates/cli/lib/commands/config.ts | Adds "bigint" to the type enum in both AttributeSchema and ColumnSchema; no other schema changes needed since int64Schema for min/max was already in place. |
| templates/cli/lib/commands/utils/attributes.ts | Adds case "bigint" to both createAttribute and updateAttribute, calling createBigIntAttribute/updateBigIntAttribute consistently with the integer type pattern. |
Reviews (2): Last reviewed commit: "Merge branch 'master' into big-int" | Re-trigger Greptile
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)