Conversation
0528146 to
ebc8868
Compare
|
Are you make these test run automatically with the existing tests? |
@abnegate I don't think we can do that yet. But we want to use these test to run in the |
|
@abnegate let's get this merged in a different branch and sync |
|
Quick triage check: is this PR still active? It has been inactive for a long time and there is newer testing work in the repo now. If you still plan to continue, please share status/rebase plan; otherwise we can close it for now. |
ebc8868 to
864a059
Compare
Greptile SummaryThis PR adds generated unit tests to the Python SDK, covering Confidence Score: 5/5Safe to merge — all previously blocking issues are resolved, and remaining findings are minor style suggestions. Previously flagged P0/P1 issues (debug echo, missing false→False/null→None) are fully addressed. The two remaining comments are P2: templates/python/requirements.txt.twig — minor inconsistency with pyproject.toml.twig on test dependency scoping. Important Files Changed
Reviews (5): Last reviewed commit: "chore: fix linting" | Re-trigger Greptile |
864a059 to
6f4f990
Compare
|
@ChiragAgg5k took me a little while to get to it but this one is finally ready as well 🤞 Let me know if I missed anything :) |
|
Tip: Greploop — Automatically fix all review issues by running Use the Greptile plugin for Claude Code to query reviews, search comments, and manage custom context directly from your terminal. |
What does this PR do?
This PR adds generated unit tests to the Python SDK.
Test Plan
Generate the SDK, weave hands to get the dependencies installed (my IDE did it for me, I have no clue about Python, I am sorry!), then run
python3 -m unittest.Related PRs and Issues
#680
Have you read the Contributing Guidelines on issues?
Yup
Discord username for swag as requested by Tessa: yestheory