Merge pull request #2983 from appwrite/fix/threads-jsonld-html-script-escape

eldadfux · web-flow · commit 8bc5827a96ab · 2026-05-07T10:13:45.000-04:00
Fix/threads jsonld html script escape
diff --git a/src/lib/utils/metadata.ts b/src/lib/utils/metadata.ts
@@ -13,15 +13,21 @@ export function buildOpenGraphImage(title: string, description: string): string
     )}&subtitle=${encodeURIComponent(description)}`;
 }
 
+/**
+ * Escapes `<` as the JSON unicode escape `\u003c` so the result can be embedded
+ * inside HTML `<script>` tags (including SvelteKit route data) without `</script>`
+ * or similar sequences in string values ending the script early. `JSON.parse`
+ * still yields the original `<`.
+ */
+export function escapeJsonLtForHtmlScript(json: string): string {
+    return json.replace(/</g, '\\u003c');
+}
+
 /**
  * Returns an inlined JSON-LD script tag without breaking IDE formatting.
- *
- * Escapes `<` as `\u003c` so content like `</script>` inside string values
- * (e.g. code samples in forum posts) cannot prematurely close the script element
- * in HTML; JSON.parse still yields the original `<`.
  */
 export function getInlinedScriptTag(jsonSchema: string): string {
-    const safeForInlineScript = jsonSchema.replace(/</g, '\\u003c');
+    const safeForInlineScript = escapeJsonLtForHtmlScript(jsonSchema);
     return `<script type="application/ld+json">${safeForInlineScript}</` + 'script>';
 }
 
@@ -43,7 +49,7 @@ export function organizationJsonSchema() {
         legalName: 'Appwrite Code Ltd.',
         description:
             'A secure open-source backend server provides the core APIs required to build web and mobile applications. Appwrite provides authentication, database, storage, functions, messaging, and advanced realtime capabilities.',
-        logo: 'https://appwrite.io/assets/logotype/white.avif'
+        logo: 'https://appwrite.io/assets/logotype/white.png'
     });
 }
 
@@ -246,5 +252,5 @@ export function createDiscussionForumPageSchema(options: {
         mainEntity
     };
 
-    return JSON.stringify(graph);
+    return escapeJsonLtForHtmlScript(JSON.stringify(graph));
 }
diff --git a/src/routes/(marketing)/+page.svelte b/src/routes/(marketing)/+page.svelte
@@ -1,5 +1,14 @@
 <script lang="ts">
-    import { browser } from '$app/environment';
+    import { browser, building } from '$app/environment';
+    import { page } from '$app/state';
+    import {
+        DEFAULT_HERO_CTA,
+        DEFAULT_HERO_SUBTITLE,
+        DEFAULT_HERO_TITLE
+    } from '$lib/statsig/constants';
+    import { resolveHeroQueryOverrides } from '$lib/statsig/hero-query-overrides';
+    import type { HeroLayoutVariant } from '$lib/statsig/hero-layout';
+    import type { PageData } from './$types';
     import Bento from './(components)/bento/bento.svelte';
     import CaseStudies from './(components)/case-studies.svelte';
     import Features from './(components)/features.svelte';
@@ -14,10 +23,30 @@
     import { FooterNav, MainFooter } from '$lib/components';
     import LogoList from './(components)/logo-list.svelte';
     import Ai from './(components)/ai.svelte';
+
+    /** Same baseline + query resolution as `hero.svelte`; tab title prefixes the brand. */
+    type MarketingHeroPageData = PageData & {
+        statsigBootstrap?: string | null;
+        statsigStableUserId?: string | null;
+        statsigUserAgent?: string | null;
+    };
+
+    const data = $derived(page.data as MarketingHeroPageData);
+
+    const heroPageTitle = $derived(
+        resolveHeroQueryOverrides(building ? new URLSearchParams() : page.url.searchParams, {
+            heroLayout: (data.heroLayout ?? 0) as HeroLayoutVariant,
+            heroSubtitle: data.heroSubtitle ?? DEFAULT_HERO_SUBTITLE,
+            heroTitle: data.heroTitle ?? DEFAULT_HERO_TITLE,
+            heroCta: data.heroCta ?? DEFAULT_HERO_CTA
+        }).heroTitle
+    );
+
+    const homepageDocumentTitle = $derived(`Appwrite - ${heroPageTitle}`);
 </script>
 
 <Head
-    title="Appwrite - Build like a team of hundreds"
+    title={homepageDocumentTitle}
     description="Build like a team of hundreds with Appwrite's all-in-one, open-source infrastructure. Launch in minutes, use any framework, and scale affordably with Auth, Database, Storage, Functions, Realtime, Messaging, and Sites for static sites, SSR, and CSR frontends."
 />
 
diff --git a/src/routes/threads/[id]/+page.svelte b/src/routes/threads/[id]/+page.svelte
@@ -138,7 +138,7 @@
         display: grid;
         grid-template-columns: 1fr auto;
         gap: 4rem;
-        align-items: center;
+        align-items: start;
 
         margin-block-start: 2.5rem;
     }

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@`
`138`	`138`	`display: grid;`
`139`	`139`	`grid-template-columns: 1fr auto;`
`140`	`140`	`gap: 4rem;`
`141`		`- align-items: center;`
	`141`	`+ align-items: start;`
`142`	`142`
`143`	`143`	`margin-block-start: 2.5rem;`
`144`	`144`	`}`