Skip to content

404 page text color fixed in light mode#408

Open
DevVivekk wants to merge 1 commit into
apsinghdev:mainfrom
DevVivekk:fix/404_page_text_color_on_light_mode
Open

404 page text color fixed in light mode#408
DevVivekk wants to merge 1 commit into
apsinghdev:mainfrom
DevVivekk:fix/404_page_text_color_on_light_mode

Conversation

@DevVivekk

@DevVivekk DevVivekk commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

fixes #407

Summary by CodeRabbit

  • Style
    • Enhanced the default 404 error page appearance with improved styling
    • Refined text color consistency across the application interface

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

@DevVivekk is attempting to deploy a commit to the AJEET PRATAP SINGH's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Two small CSS changes address light mode styling on the Next.js 404 page: the <body> element in RootLayout gains the text-foreground Tailwind class, and a new .next-error-h1 rule in globals.css overrides the heading's border color to hsl(var(--foreground)) with !important.

Changes

404 Light Mode Text & Border Color Fix

Layer / File(s) Summary
Body text color and 404 heading border override
apps/web/src/app/layout.tsx, apps/web/src/app/globals.css
RootLayout's <body> gains text-foreground Tailwind class; globals.css adds .next-error-h1 { border-color: hsl(var(--foreground)) !important; } to correct the 404 heading border in light mode.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 Hippity hop, the 404 was dim,
In light mode the colors were ever so grim.
A dash of text-foreground, a border set right,
Now the lost little page shines perfectly bright!
No more dark-on-dark — what a bunny delight! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR addresses issue #407's requirement to improve 404 page text readability in light mode by updating CSS styling for the error page element and body text color.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the 404 page text color issue in light mode; no out-of-scope modifications detected.
Title check ✅ Passed The title clearly reflects the main fix: improving 404 page readability in light mode.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DevVivekk DevVivekk changed the title 404_page_text_color_fixed_in_light_mode 404 page text color fixed in light mode Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 404 Page Text Color Not changing in Light Mode

1 participant