Skip to content

Adopt spaniter v0.1.0 row iterator adapters#44

Merged
apstndb merged 2 commits into
mainfrom
adopt-spaniter
Jun 25, 2026
Merged

Adopt spaniter v0.1.0 row iterator adapters#44
apstndb merged 2 commits into
mainfrom
adopt-spaniter

Conversation

@apstndb

@apstndb apstndb commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • update github.com/apstndb/spaniter from v0.1.0-alpha.1 to v0.1.0
  • use spaniter row-iterator lifecycle helpers for metadata/stats capture
  • preserve eager PROFILE stats when --redact-rows drains rows without materializing them
  • document that redacted eager result sets may have nil rows while still preserving metadata and stats

Validation

  • go test ./...
  • make test
  • git diff --check

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates the github.com/apstndb/spaniter library to handle Spanner row iterator draining and sequencing, replacing custom iterator helpers in main.go and integration_test.go. It also introduces BuildResultSetFromParts in jqresult/protojson.go to support constructing result sets with redacted rows while preserving metadata and query stats, and adds a corresponding integration test. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@apstndb apstndb marked this pull request as ready for review June 25, 2026 16:51
@apstndb apstndb merged commit 0226fd5 into main Jun 25, 2026
2 checks passed
@apstndb apstndb deleted the adopt-spaniter branch June 25, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant