Remove xiter dependency#54
Conversation
Replace RowToListValue indexing with lo.Map, collect emulator test rows with a local helper, and delete unused internal helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the spheric.cloud/xiter dependency, cleans up unused utility functions in the internal package, and replaces xiter usages with standard library iterators or alternative implementations. In resultset/row.go, the use of lo.Map and lo.Range introduces unnecessary overhead and allocations; it is recommended to replace this with a simple, idiomatic for loop and a pre-allocated slice to improve performance and eliminate the github.com/samber/lo dependency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Replace lo.Map/lo.Range with a simple loop per review feedback. Co-authored-by: Cursor <cursoragent@cursor.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request removes the external dependency spheric.cloud/xiter and simplifies the codebase. Specifically, it deletes unused helper functions in the internal package, replaces xiter.TryCollect with a local collectRows helper in integration_test.go, and refactors RowToListValue in resultset/row.go to use a standard loop instead of iterator-based collection. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Summary
spheric.cloud/xiterfromgo.mod; usegithub.com/samber/loand stdlibiterinstead.RowToListValuewithlo.Map/lo.Range.xiter.TryCollectin integration tests with a small localcollectRowshelper.internal/util.go(only referenced xiter helpers).Test plan
go test ./...Made with Cursor