Skip to content

build(deps): bump fzf to 0.73.0#634

Merged
apstndb merged 2 commits into
mainfrom
deps/fzf-0.73.0
May 24, 2026
Merged

build(deps): bump fzf to 0.73.0#634
apstndb merged 2 commits into
mainfrom
deps/fzf-0.73.0

Conversation

@apstndb

@apstndb apstndb commented May 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Bump github.com/junegunn/fzf from v0.68.0 to v0.73.0
  • Use fzf's inline header border for fuzzy finder headers
  • Document the new built-in header border default and clarify that both --tmux and its newer --popup alias are unsupported with the in-process fzf runner

Verification

  • go test ./internal/mycli -run 'TestPrepareFzfOptions|TestRunFzfFilter'
  • go test ./internal/mycli -run 'TestRun/embedded_emulator_success|TestRuntimePlatform' -count=1
  • DOCKER_HOST=$(colima status --json | jq -r .docker_socket) TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE=/var/run/docker.sock make check
  • go mod verify

Copilot AI review requested due to automatic review settings May 24, 2026 18:27

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the fzf dependency to version 0.73.0 and introduces the --header-border=inline option when a header is displayed in the fuzzy finder. Documentation in README.md and system_variables.md has been updated to reflect new built-in defaults and the lack of support for the --popup option. The implementation in fuzzy_finder.go now correctly calculates the display height by accounting for the additional line required by the inline header border, and the test suite has been expanded to cover these changes. I have no feedback to provide.

@github-actions

github-actions Bot commented May 24, 2026

Copy link
Copy Markdown

Code Metrics Report

📊 View detailed coverage report (available for 7 days)

main (06dc2e9) #634 (ff4c5e0) +/-
Coverage 71.6% 71.6% +0.0%
Code to Test Ratio 1:1.3 1:1.3 +0.0
Test Execution Time 1m42s 42s -1m0s
Details
  |                     | main (06dc2e9) | #634 (ff4c5e0) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          71.6% |          71.6% | +0.0% |
  |   Files             |             81 |             81 |     0 |
  |   Lines             |           7336 |           7338 |    +2 |
+ |   Covered           |           5253 |           5255 |    +2 |
+ | Code to Test Ratio  |          1:1.3 |          1:1.3 |  +0.0 |
  |   Code              |          16927 |          16930 |    +3 |
+ |   Test              |          22345 |          22355 |   +10 |
+ | Test Execution Time |          1m42s |            42s | -1m0s |

Code coverage of files in pull request scope (29.2% → 29.6%)

Files Coverage +/- Status
internal/mycli/fuzzy_finder.go 29.6% +0.3% modified

Reported by octocov

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the embedded fuzzy finder integration by bumping the github.com/junegunn/fzf dependency and adjusting the UI defaults to use fzf’s inline header border when a header is present, along with accompanying documentation and test updates.

Changes:

  • Bump github.com/junegunn/fzf from v0.68.0 to v0.73.0 (and update related indirect deps in go.mod/go.sum).
  • Add --header-border=inline when an fzf header is set, and adjust multiline height calculation accordingly.
  • Update docs to mention the new header-border default and clarify unsupported --tmux / --popup.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
README.md Documents updated built-in fzf defaults and unsupported options.
internal/mycli/fuzzy_finder.go Adds --header-border=inline when header is present; adjusts multiline height calculation.
internal/mycli/fuzzy_finder_test.go Extends tests to assert header-border arg and updates height expectation comments.
docs/system_variables.md Updates CLI_FUZZY_FINDER_OPTIONS docs for new default/unsupported options.
go.mod Bumps fzf and indirect go-isatty versions.
go.sum Updates checksums for bumped dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread docs/system_variables.md Outdated
Comment thread internal/mycli/fuzzy_finder.go
Comment thread internal/mycli/fuzzy_finder_test.go

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

@apstndb apstndb merged commit ddf2ce3 into main May 24, 2026
4 checks passed
@apstndb apstndb deleted the deps/fzf-0.73.0 branch May 24, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants