Skip to content

buffer bound handling in jemalloc stats callback to avoid unintended growth #19334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmestwa-coder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

buffer bound handling in jemalloc stats callback to avoid unintended growth #19334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/aptos-admin-service/src/server/malloc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,13 @@ unsafe extern "C" fn write_cb(buf: *mut c_void, s: *const c_char) {
let out = unsafe { &mut *(buf as *mut Vec<u8>) };
let stats_cstr = unsafe { CStr::from_ptr(s).to_bytes() };
// We do not want any memory allocation in the callback.
let len = std::cmp::min(out.capacity(), stats_cstr.len());
out.extend_from_slice(&stats_cstr[0..len]);
let remaining = out.capacity().saturating_sub(out.len());
if remaining == 0 {
return;
}

let len = std::cmp::min(remaining, stats_cstr.len());
out.extend_from_slice(&stats_cstr[..len]);
}

fn get_jemalloc_stats_string(max_len: usize) -> anyhow::Result<String> {
Expand Down
Loading