fix rotate-key crash when no default profile exists#19335
Open
knQzx wants to merge 1 commit into
Open
Conversation
gregnazario
approved these changes
Apr 6, 2026
Contributor
|
This issue is stale because it has been open 45 days with no activity. Remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
test plan
fixes #9547
Note
Low Risk
Low risk: changes are limited to CLI profile/config handling when saving the rotated key, mainly adding existence checks and fallbacks to defaults.
Overview
aptos account rotate-keyno longer crashes when run without an existing CLI config or a default profile.The command now checks whether a config file exists before loading it during profile-name validation, creates a default config when saving a new profile if none exists, and builds the new
ProfileConfigusing a default base profile when the current profile can’t be loaded.Reviewed by Cursor Bugbot for commit 60e169f. Bugbot is set up for automated code reviews on this repo. Configure here.