[consensus] Strict leader reputation with 1 faulty validator at 4k TPS#19336
Closed
danielxiangzl wants to merge 1 commit into
Closed
[consensus] Strict leader reputation with 1 faulty validator at 4k TPS#19336danielxiangzl wants to merge 1 commit into
danielxiangzl wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
25b75ac to
d71ffbd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Closed
1 task
a60f109 to
d0184cb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d0184cb to
c20182d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c20182d to
79aa371
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e1b0a8c to
4b93869
Compare
4485f9d to
30a41f4
Compare
4b93869 to
f9c944c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
On top of the baseline latency experiment. Sets failure_window_num_validators_multiplier=50 so failed validators stay penalized for ~4.7 min instead of the default ~56s. Also includes the separate failure window field added to ProposerAndVoterConfig and consensus config plumbing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
78398c9 to
a9e825c
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
✅ Forge suite
|
Contributor
Author
|
Closing in favor of the consolidated weighted-leader approach in #19343 (canonical) + #19341 (forge experiment). The fixed LatencyWeightedHeuristic combined with proposer_window_num_validators_multiplier=50 provides continuous downweighting of slow/failing validators without needing the asymmetric strict-classification hack. See discussion in #19343. |
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daniel/latency-baseline-by-skip+daniel/strict-leadercombinedrealistic_env_max_loadat ConstTps 4k with 1 faulty validator (last by index, skips 50% of proposals)failure_window_num_validators_multiplieradded (default 0, falls back to proposer window)Test plan
land_blockingand compare latency againstdaniel/latency-baseline-by-skip(PR [forge] Latency baseline with 1 slow validator at 4k TPS #19330)🤖 Generated with Claude Code