This repository was archived by the owner on Jul 30, 2025. It is now read-only.
[gha/test] Add canary branch for external contributors build lint#992
Merged
rustielin merged 1 commit intoJul 3, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rustielin
marked this pull request as ready for review
June 18, 2025 22:44
rustielin
force-pushed
the
06-18-_gha_allow_external_contributors_build_lint
branch
2 times, most recently
from
June 18, 2025 23:02
c451f29 to
7675e73
Compare
rustielin
force-pushed
the
06-18-_gha_canary_allow_external_contributors_build_lint
branch
from
June 18, 2025 23:02
1907e47 to
498d84a
Compare
gregnazario
approved these changes
Jul 1, 2025
rustielin
changed the title
rustielin
changed the title
Contributor
Author
Merge activity
|
rustielin
changed the base branch from
06-18-_gha_allow_external_contributors_build_lint
to
graphite-base/992
July 3, 2025 17:54
rustielin
added a commit
that referenced
this pull request
Jul 3, 2025
This PR introduces `pull_request_target` for the main CI build/lint job. It requires permissions since there are some internal packages that are used in part of the build. The `permission-check` job ensures the permissions are locked down, and Semgrep enforces that job's existence. This PR is tested by #992 , which should be safe to land alongside it as long as Semgrep passes on it
rustielin
force-pushed
the
06-18-_gha_canary_allow_external_contributors_build_lint
branch
from
July 3, 2025 18:17
498d84a to
31984cc
Compare
rustielin
deleted the
06-18-_gha_canary_allow_external_contributors_build_lint
branch
July 3, 2025 18:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canary for #991
It works because in this stack, this PR is targeting the branch
06-18-_gha_allow_external_contributors_build_lint, so underpull_request_target, it will use theci.ymlworkflow file from that branch.Test plan
CI works, and Semgrep passes