Make tune_chunk_size a top-level config field#210
Open
GMNGeoffrey wants to merge 1 commit into
Open
Conversation
Setting this in any location sets it for all locations because it's a field reference, so I think it makes sense to have this settable at the top-level along with chunk size. Otherwise you have to pick one arbitrary module to set it in, and I think having done that it's surprising that it gets set everywhere. This matches the behavior of similar fields `per_sample_token_cutoff`, `per_sample_atom_cutoff`, and `low_mem_validation`. An alternative would be to unlink the module-level settings so they could be set independently (and optionally having a top-level setting that controls the default).
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently
tune_chunk_sizeis a field reference used in various subconfigs. Setting it in any of htem changes the value in all of them. I think given that, it makes sense to have one obviously canonical top-level place to set it. Otherwise you have to pick one arbitrary module to set it in, and I think having done that it's surprising that it gets set everywhere. This matches the behavior of similar fieldsper_sample_token_cutoff,per_sample_atom_cutoff, andlow_mem_validation.An alternative would be to unlink the module-level settings so they could be set independently (and optionally having a top-level setting that controls the default).
Changes
Add
tune_chunk_sizetosettings.memory.eval.Related Issues
None
Testing
Ran examples manually using the setting here or in any one of the modules and confirmed chunk tuning is turned off everywhere.