Merge pull request #13 from ara-framework/fix/upgrade-execa

Fix/upgrade execa

Author: marconi1992

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ara-cli",
-  "version": "1.0.0-alpha.2",
+  "version": "1.0.0-alpha.3",
   "description": "Ara Framework Command Line Interface",
   "keywords": [
     "ara",
@@ -25,7 +25,7 @@
     "cac": "^6.5.2",
     "chalk": "^2.4.2",
     "download": "^7.1.0",
-    "execa": "^2.0.4",
+    "execa": "^3.3.0",
     "majo": "^0.8.0",
     "ora": "^3.4.0",
     "s3rver": "^3.3.0",

src/index.js

@@ -10,7 +10,7 @@ const runProxy = require('./run/proxy');
 const runCluster = require('./run/cluster');
 
 cli.command('new:project <outDir>', 'New Project')
-  .action(outDir => generateProject(outDir));
+  .action((outDir) => generateProject(outDir));
 
 cli.command('new:nova <outDir>', 'New Micro-Frontend')
   .option('-t, --template <template>', 'Template Type')

src/run/asset.js

@@ -7,7 +7,7 @@ const corsConfig = require.resolve('s3rver/example/cors.xml');
 const defaultBucket = 'assets';
 
 module.exports = (webpackConf) => {
-  const [clientConf] = webpackConf.filter(conf => conf.target === 'web');
+  const [clientConf] = webpackConf.filter((conf) => conf.target === 'web');
 
   if (!clientConf) {
     throw Error('Missing webpack configuration with target set as "web"');
@@ -62,7 +62,7 @@ module.exports = (webpackConf) => {
           ContentType: 'text/javascript',
           Body: fs.readFileSync(path.join(outputPath, fileName)),
         }).promise()
-          .catch(e => console.error(e))
+          .catch((e) => console.error(e))
           .then(() => console.log(chalk.green(`Client script in "${defaultBucket}" bucket`)));
       });
     }

src/run/cluster.js

@@ -27,7 +27,8 @@ module.exports = async (config, dest) => {
         fs.chmodSync(executable, 755);
         spinner.succeed('Downloaded nova-cluster');
       } catch (error) {
-        spinner.fail('Downloadind nova-cluster failed');
+        console.error(error);
+        spinner.fail('Downloading nova-cluster failed');
         return null;
       }
     } else {
@@ -38,9 +39,13 @@ module.exports = async (config, dest) => {
   try {
     process.env.CONFIG_FILE = process.env.CONFIG_FILE || config;
 
-    execa(executable).stdout.pipe(process.stdout);
+    const child = execa(executable);
+
+    child.stdout.pipe(process.stdout);
+    child.stderr.pipe(process.stderr);
   } catch (error) {
-    console.error(chalk.red(error.stderr || 'Nova cluster failed when running'));
+    console.error(error);
+    console.error(chalk.red('Nova cluster failed when running'));
   }
 
   return null;

src/run/lambda.js

@@ -8,7 +8,7 @@ module.exports = (handler, webpackConf) => {
   const webpack = require('webpack');
   const ServerlessOffline = require('serverless-offline/src/ServerlessOffline');
 
-  const [serverConf] = webpackConf.filter(conf => conf.target === 'node');
+  const [serverConf] = webpackConf.filter((conf) => conf.target === 'node');
 
   if (!serverConf) {
     throw Error('Missing webpack configuration with target set as "node"');
@@ -86,7 +86,7 @@ module.exports = (handler, webpackConf) => {
     isWatching = true;
 
     return Promise.resolve(slsOffline._buildServer())
-      .then(server => server.start());
+      .then((server) => server.start());
   });
 
   return compiler;

src/run/proxy.js

@@ -27,7 +27,8 @@ module.exports = async (config, dest) => {
         fs.chmodSync(executable, 755);
         spinner.succeed('Downloaded nova-proxy');
       } catch (error) {
-        spinner.fail('Downloadind nova-proxy failed');
+        console.error(error);
+        spinner.fail('Downloading nova-proxy failed');
         return null;
       }
     } else {
@@ -42,9 +43,13 @@ module.exports = async (config, dest) => {
       return console.error(chalk.red('HYPERNOVA_BATCH environment variable is required'));
     }
     console.log(chalk.green('Nova proxy running!!'));
-    await execa(executable);
+    const child = execa(executable);
+
+    child.stdout.pipe(process.stdout);
+    child.stderr.pipe(process.stderr);
   } catch (error) {
-    console.error(chalk.red(error.stderr || 'Nova proxy failed when running'));
+    console.error(error);
+    console.error(chalk.red('Nova proxy failed when running'));
   }
 
   return null;